339314 - remove the unnecessary nsMaiInterface classes

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Ginn Chen]

Comment 1

[Ginn Chen]

Attachment: patch

move CB function declarations to nsMaiInterfaceXXX.h and NOT use static;
remove codes relates to nsMaiInterfaceXXX classes;
remove nsIAccessibleAction.idl, we didn't implement it

Comment 2

[Aaron Leventhal]

Comment on attachment 223429 [details] [diff] [review]
patch

Cool! r+

Nit -- no new patch necessary:
for (int index = 0; index < MAI_INTERFACE_NUM; index++) ;
It's a little cleaner to use NS_ARRAY_LENGTH(), then you don't need a magic value at the end.

Also, as we have stated in the m.d.planning newsgroup, we're will only request sr= for checkin to trunk at the request of the reviewer, and I'm not asking for that. However, feel free to ask for an sr= or 2nd review from a colleague if it makes you more comfortable with this large change. It can be someone else on your team.