[BeOS]Firefox - mozilla/browser/app needs resource file for BeOS

RESOLVED FIXED

Status

()

Firefox
General
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Doug Shelton, Unassigned)

Tracking

({fixed1.8.1})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060529 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060529 Minefield/3.0a1

For system integration (mime-types, default handlers etc) BeOS application
require proper file attributes (metadata) to be set.

Reproducible: Always
(Reporter)

Comment 1

12 years ago
Created attachment 223952 [details]
Proposed resource file
(Reporter)

Comment 2

12 years ago
Created attachment 223953 [details] [diff] [review]
Patch to include resource file in Makefile
(Reporter)

Updated

12 years ago
Attachment #223953 - Flags: review?(sergei_d)
(Reporter)

Updated

12 years ago
Attachment #223952 - Flags: review?(sergei_d)

Comment 3

12 years ago
Comment on attachment 223952 [details]
Proposed resource file

r=sergei_d

Needs some automation to be added in future in Makefile, about current version and such
Attachment #223952 - Flags: review?(sergei_d) → review+

Comment 4

12 years ago
Comment on attachment 223953 [details] [diff] [review]
Patch to include resource file in Makefile

r=sergei_d

See previous comment
Attachment #223953 - Flags: review?(sergei_d) → review+
(Reporter)

Updated

12 years ago
Attachment #223952 - Flags: superreview?(ajshaver)
(Reporter)

Updated

12 years ago
Attachment #223952 - Flags: superreview?(ajshaver) → superreview?(shaver)
(Reporter)

Updated

12 years ago
Attachment #223953 - Flags: superreview?(shaver)
(Reporter)

Updated

12 years ago
Attachment #223952 - Flags: superreview?(shaver) → superreview?(neil)
(Reporter)

Updated

12 years ago
Attachment #223953 - Flags: superreview?(shaver) → superreview?(neil)

Comment 5

12 years ago
Comment on attachment 223952 [details]
Proposed resource file

Platform-specific code, no superreview required.
Attachment #223952 - Flags: superreview?(neil)

Comment 6

12 years ago
Comment on attachment 223953 [details] [diff] [review]
Patch to include resource file in Makefile

Build config change so over to bsmedberg for second review.
Attachment #223953 - Flags: superreview?(neil) → superreview?(benjamin)
(Reporter)

Updated

12 years ago
Blocks: 311032
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

12 years ago
Attachment #223953 - Flags: superreview?(benjamin) → superreview+
(Reporter)

Updated

12 years ago
Status: NEW → ASSIGNED

Updated

12 years ago
Summary: [BeOS] mozilla/browser/app needs resource file for BeOS → [BeOS]Firefox - mozilla/browser/app needs resource file for BeOS

Comment 7

12 years ago
Checking in mozilla/browser/app/Makefile.in;
/cvsroot/mozilla/browser/app/Makefile.in,v  <--  Makefile.in
new revision: 1.105; previous revision: 1.104
done
RCS file: /cvsroot/mozilla/browser/app/apprunner-beos.rsrc,v
done
Checking in mozilla/browser/app/apprunner-beos.rsrc;
/cvsroot/mozilla/browser/app/apprunner-beos.rsrc,v  <--  apprunner-beos.rsrc
initial revision: 1.1
done 
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 8

12 years ago
Comment on attachment 223953 [details] [diff] [review]
Patch to include resource file in Makefile

Asking approval for adding beos resource file and corresponding change in BeOS section of Makefile.in for 1.8.1 branch.
No other platfrom affected, BeOS-only
Attachment #223953 - Flags: approval1.8.1?
Comment on attachment 223953 [details] [diff] [review]
Patch to include resource file in Makefile

a=drivers, so say we all
Attachment #223953 - Flags: approval1.8.1? → approval1.8.1+

Comment 10

12 years ago
Hope beltzner didn't get carpal tunnel syndropme with our backported patch flood:)

Checking in mozilla/browser/app/Makefile.in;
/cvsroot/mozilla/browser/app/Makefile.in,v  <--  Makefile.in
new revision: 1.85.2.9; previous revision: 1.85.2.8
done
Checking in mozilla/browser/app/apprunner-beos.rsrc;
/cvsroot/mozilla/browser/app/apprunner-beos.rsrc,v  <--  apprunner-beos.rsrc
new revision: 1.1.4.1; previous revision: 1.1
done
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.