Closed Bug 339843 Opened 19 years ago Closed 19 years ago

[BeOS]Firefox - mozilla/browser/app needs resource file for BeOS

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
x86
BeOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: doug, Unassigned)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files)

Proposed resource file
8.24 KB, application/zip
sergei_d
: review+
Details
Patch to include resource file in Makefile
668 bytes, patch
sergei_d
: review+
benjamin
: superreview+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060529 Minefield/3.0a1 Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060529 Minefield/3.0a1 For system integration (mime-types, default handlers etc) BeOS application require proper file attributes (metadata) to be set. Reproducible: Always
Attached file Proposed resource file —
Attachment #223953 - Flags: review?(sergei_d)
Attachment #223952 - Flags: review?(sergei_d)
Comment on attachment 223952 [details] Proposed resource file r=sergei_d Needs some automation to be added in future in Makefile, about current version and such
Attachment #223952 - Flags: review?(sergei_d) → review+
Comment on attachment 223953 [details] [diff] [review] Patch to include resource file in Makefile r=sergei_d See previous comment
Attachment #223953 - Flags: review?(sergei_d) → review+
Attachment #223952 - Flags: superreview?(ajshaver)
Attachment #223952 - Flags: superreview?(ajshaver) → superreview?(shaver)
Attachment #223953 - Flags: superreview?(shaver)
Attachment #223952 - Flags: superreview?(shaver) → superreview?(neil)
Attachment #223953 - Flags: superreview?(shaver) → superreview?(neil)
Comment on attachment 223952 [details] Proposed resource file Platform-specific code, no superreview required.
Attachment #223952 - Flags: superreview?(neil)
Comment on attachment 223953 [details] [diff] [review] Patch to include resource file in Makefile Build config change so over to bsmedberg for second review.
Attachment #223953 - Flags: superreview?(neil) → superreview?(benjamin)
Blocks: 311032
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #223953 - Flags: superreview?(benjamin) → superreview+
Status: NEW → ASSIGNED
Summary: [BeOS] mozilla/browser/app needs resource file for BeOS → [BeOS]Firefox - mozilla/browser/app needs resource file for BeOS
Checking in mozilla/browser/app/Makefile.in; /cvsroot/mozilla/browser/app/Makefile.in,v <-- Makefile.in new revision: 1.105; previous revision: 1.104 done RCS file: /cvsroot/mozilla/browser/app/apprunner-beos.rsrc,v done Checking in mozilla/browser/app/apprunner-beos.rsrc; /cvsroot/mozilla/browser/app/apprunner-beos.rsrc,v <-- apprunner-beos.rsrc initial revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 223953 [details] [diff] [review] Patch to include resource file in Makefile Asking approval for adding beos resource file and corresponding change in BeOS section of Makefile.in for 1.8.1 branch. No other platfrom affected, BeOS-only
Attachment #223953 - Flags: approval1.8.1?
Comment on attachment 223953 [details] [diff] [review] Patch to include resource file in Makefile a=drivers, so say we all
Attachment #223953 - Flags: approval1.8.1? → approval1.8.1+
Hope beltzner didn't get carpal tunnel syndropme with our backported patch flood:) Checking in mozilla/browser/app/Makefile.in; /cvsroot/mozilla/browser/app/Makefile.in,v <-- Makefile.in new revision: 1.85.2.9; previous revision: 1.85.2.8 done Checking in mozilla/browser/app/apprunner-beos.rsrc; /cvsroot/mozilla/browser/app/apprunner-beos.rsrc,v <-- apprunner-beos.rsrc new revision: 1.1.4.1; previous revision: 1.1 done
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: