Crash in spellchecker checking absurdly long word

RESOLVED FIXED in mozilla1.8.1beta2

Status

()

Core
Spelling checker
--
critical
RESOLVED FIXED
12 years ago
7 years ago

People

(Reporter: roc, Assigned: Brett Wilson)

Tracking

({crash, fixed1.8.1, verified1.8.1.3})

1.8 Branch
mozilla1.8.1beta2
crash, fixed1.8.1, verified1.8.1.3
Points:
---
Bug Flags:
blocking1.8.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Try loading the testcase here and enabling spellchecking in the edit control:

https://bugzilla.mozilla.org/attachment.cgi?id=219142&action=edit

(You may crash just trying to display the testcase, in which case you'll have to wait for bug 302294 to be fixed before you work on this.)

If I enable spellchecking then click around a fair bit, including right-clicking on the word to get a popup, I eventually crash in mozMySpell::Suggest doing an illegal free.
Created attachment 224159 [details]
gdb stack

Updated

12 years ago
Flags: blocking1.9a1?
Flags: blocking1.8.1?

Updated

12 years ago
Flags: blocking1.8.1? → blocking1.8.1+

Updated

12 years ago
Severity: normal → major
Keywords: crash
Target Milestone: --- → mozilla1.8.1beta2
Whiteboard: [at risk]
(Assignee)

Comment 2

12 years ago
Created attachment 230764 [details] [diff] [review]
Patch

This seems to fix the problem. It filters out very long words from myspell. I'm a little worried because I don't understand the source of the problem, and there could be more problems with word handling in myspell.
Attachment #230764 - Flags: review?(roc)
Attachment #230764 - Flags: superreview+
Attachment #230764 - Flags: review?(roc)
Attachment #230764 - Flags: review+
(Assignee)

Comment 3

12 years ago
Fixed on trunk.
Assignee: mscott → brettw
OS: Linux → All
Hardware: PC → All
Whiteboard: [at risk]
Version: Trunk → 1.8 Branch
(Assignee)

Updated

12 years ago
Attachment #230764 - Flags: approval1.8.1?

Updated

12 years ago
Attachment #230764 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Comment 4

12 years ago
Now it's really fixed on trunk.
(Assignee)

Comment 5

12 years ago
The first comment about fixing it on trunk was actually a branch checkin.
Keywords: fixed1.8.1
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Flags: blocking1.9a1?
Resolution: --- → FIXED
verified fixed 1.8.1.3 on Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4pre) Gecko/2007040403 BonEcho/2.0.0.4pre and also Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 using the testcase in this bug
Keywords: verified1.8.1.3

Updated

7 years ago
Depends on: 629719

Updated

7 years ago
Severity: major → critical
You need to log in before you can comment on or make changes to this bug.