340451 - Remove nsISVGRendererRegion

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

Comment 1

[tor]

Attachment: remove nsISVGRenderRegion, store region in nsIFrame::mRect

Comment 2

[Robert Longson [:longsonr]]

Could we take this opportunity to replace if (!text.Length()) and if (text.Length() == 0) code by if (text.IsEmpty()) in nsSVGCairoGlyphGeometry.cpp? There are 3 instances of this.

I was going to slip this into bug 339039 but I think it is better done here as you are changing this code anyway. I can submit a new patch for bug 339039 or you can just ignore the nsSVGCairoGlyphGeometry.cpp changes if you wish. Alternatively I could raise another bug after you have checked this change in.

Comment 3

[tor]

I'd prefer to keep unrelated changes seperate from either of those bugs for the sake of cvs history.

Comment 4

[tor]

Attachment: merge to tip

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

nsRect is integers (currently). Don't we want to keep these rects using floats? If so, I think you should define nsFloatRect in nsRect.h.

Comment 6

[tor]

The covered region is only used for screen coverage information in invalidation and early hit rejection, so it seems that integers would be a natural fit.

The bounding box calculation on the other hand does need floating point storage.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 224708 [details] [diff] [review]
merge to tip

Right, OK.

Document that nsSVGOuterSVGFrame::InvalidateRect takes a rect in pixels.

I'd prefer InflateRect to be named something else ... perhaps ToBoundingPixelRect.

+  aRect *= GetTwipsPerPx();
+  vm->UpdateView(view, aRect, NS_VMREFRESH_NO_SYNC);

I think you should call ScaleRoundOut here.

Comment 8

[tor]

Attachment: version for checkin, with suggested changes

Comment 9

[tor]

Checked in.