340581 - Text not rendering correctly in SVG on Intel Mac

Status: VERIFIED FIXED

(Core :: SVG, defect)

Description

[Amos Hayes]

Most colours of <svg:text> are not rendered, including black (the default).

Affects the following builds:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3

Does not affect:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3

Comment 1

[Amos Hayes]

Attachment: This demonstrates the problem when run natively intel macs.

Attached test case that should render text in a few different colours.

Comment 2

[Amos Hayes]

This bug is a followup to bug 327744.

Comment 3

[tor]

Attachment: branch patch for intel atsui fonts

Comment 4

[Amos Hayes]

Just in case you wanted to test another mac-intel patch Josh. :)

Comment 5

[Amos Hayes]

Tor, sorry to be a newbie, but if I wanted to test this patch, which branch would I check out?

Comment 6

[tor]

Either MOZILLA_1_8_BRANCH (ff2) or MOZILLA_1_8_0_BRANCH (ff1.5.x) would be fine.

Comment 7

[Josh Aas]

Also when you configure, you'll need to enable svg and canvas in your mozconfig file. It isn't enabled by default, at least on the MOZILLA_1_8_BRANCH.

ac_add_options --enable-canvas
ac_add_options --enable-svg

Comment 8

[tor]

Comment on attachment 225028 [details] [diff] [review]
branch patch for intel atsui fonts

Tested - this does fix the problem on intel OS-X.

Comment 9

[tor]

Attachment: missing include for older SDKs

Comment 10

[Amos Hayes]

Thanks for the new patch tor. I have tested this patch on the MOZILLA_1_8_0 branch using the universal build instructions at:

http://developer.mozilla.org/en/docs/Mac_OS_X_Universal_Binaries

plus the following additions to the .mozconfig:

ac_add_options --enable-canvas
ac_add_options --enable-svg

and confirm that the text now renders properly on intel mac. I also tried setting my build to "Open using Rosetta" and confirm that the above test case still works there too.

Comment 11

[Mike Shaver (:shaver emeritus)]

Comment on attachment 225328 [details] [diff] [review]
missing include for older SDKs

181=shaver, thanks!

Drivers: should definitely take this on 1.8.0.5, it's  a nasty parity bug.

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Please make sure this gets into upstream cairo as well so it doesn't get lost when we update cairo.

Comment 13

[tor]

This is already upstream as far as I can tell.

Comment 14

[tor]

Checked in on MOZILLA_1_8_BRANCH.

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 225328 [details] [diff] [review]
missing include for older SDKs

approved for 1.8.0 branch, a=dveditz for drivers

Comment 16

[tor]

Checked in on MOZILLA_1_8_0_BRANCH.

Comment 17

[juan becerra [:juanb]]

Verified with test case provided on: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.5) Gecko/20060619 Firefox/1.5.0.5

Comment 18

[Ryan Flint [:rflint] (ping via IRC for reviews)]

*** Bug 344781 has been marked as a duplicate of this bug. ***