340807 - My dictionary disappeared, and now Firefox thinks everything is misspelled

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060607 Minefield/3.0a1

My dictionary disappeared, and now Firefox thinks everything is misspelled!

Comment 1

[Jesse Ruderman]

Attachment: screenshot

Comment 2

[Phil Ringnalda (:philor)]

Seems likely to be from bug 151040

Comment 3

[Phil Ringnalda (:philor)]

Works in 2006060306, fails in 2006060406, seems quite likely to be 151040.

Comment 4

[Mike Pinkerton (not reading bugmail)]

weird, as this is fine in camino and the spellcheck stuff just pretends to bundle itself exactly like the MySpell shared lib. is the firefox build system somehow different in this regard?

Comment 5

[Mike Pinkerton (not reading bugmail)]

so i debugged this and it seems that the call to [NSSpellChecker sharedSpellChecker] is returning nil in firefox, where it works fine in camino.

This baffles me, as the library is linked against Cocoa and Foundation. Do we have to make firefox itself link against cocoa directly? Ideas?

Comment 6

[Mark Mentovai]

I'll look at this later today.

Comment 7

[Mark Mentovai]

This is caused by using Cocoa in a Carbon app.  Some Cocoa code can't be used in a non-Cocoa app unless Cocoa is explicitly initialized first, by calling NSApplicationLoad().  Unfortunately, NSApplicationLoad() is not without side effects: when we call it on 10.3, we get browser content that doesn't draw, etc., etc.  We only found out about this a couple of weeks ago.

Unfortunately, this pretty much renders the system dictionary integration unusable unless Cocoa widgets are in use.

Comment 8

[Mark Mentovai]

Attachment: Only use osxspell with cocoa widgets

Comment 9

[Jesse Ruderman]

Will this mean that Mac users upgrading from Firefox 2 to Firefox 3 will lose their custom dictionaries?

Comment 10

[Håkan Waara]

AFAICS, no, it means spellchecking won't be available in Firefox 2 on mac - you'll have to use Camino or wait for Cocoafox to go live.

Comment 11

[Jesse Ruderman]

The cross-platform spell-checker worked fine on Mac last week...

Comment 12

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 225477 [details] [diff] [review]
Only use osxspell with cocoa widgets

r=pink

this enables the XP spellchecker for carbon firefox (1.8branch) so it's back to normal.

drat. oh well, works for camino, and will for FF3 :D

Comment 13

[Mark Mentovai]

Fix is in.

Comment 14

[Patrick]

This check-in also fixed the older bug 340508.