340994 - FOAF tries to use feed preview mode, but fails with TypeError

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Doug Wright]

Expected behaviour: Either displaying raw XML or a pretty display

Actual behaviour: Tries to use feed preview, but fails miserably displaying the following message
   

There was an error processing this feed. It's our fault. :-( You can still subscribe to the feed if you know what it is. For reference, the error was:

      

TypeError: container has no properties

Comment 1

[Robert Sayre]

The sniffer shouldn't send this to the feed parser in the first place, so see bug 341040. However, the feed parser can cope with bogus input better.

Comment 2

[Mike Connor [:mconnor]]

SWAG?

Comment 3

[Robert Sayre]

Attachment: result.doc can be null

This patch accounts for this in FP_sendResult, but you'll also need to handle this in FeedConverter.js. Is there a way to force text/xml processing in a new request?

There's also a sniffer bug here.

Comment 4

[Robert Sayre]

(In reply to comment #3)
> 
> There's also a sniffer bug here.
> 

bug 341040

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

I think the friendly error message is nicer than showing the user the raw XML at first pass, but we should probably have some way for the user to get to that source. For example, adding a "See the contents of the file ..." link to the bottom of the error message which then loads the raw file.

Or just telling them about view source, but then I guess they don't get the expand/collapse controls.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 228694 [details] [diff] [review]
result.doc can be null

r=me, guessing Ben's probably overloaded since this has sat for a long time.

Comment 7

[Mike Connor [:mconnor]]

Robert, can you file a separate bug on the front end portion and resolve this?

Comment 8

[Robert Sayre]

Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.8; previous revision: 1.7
done
Checking in public/nsIFeedResult.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedResult.idl,v  <--  nsIFeedResult.idl
new revision: 1.2; previous revision: 1.1
done

Comment 9

[Robert Sayre]

(In reply to comment #7)
> Robert, can you file a separate bug on the front end portion and resolve this?
> 

Bug 346312, but drivers better blockerize that ;)

Comment 10

[Robert Sayre]

Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.1.2.9; previous revision: 1.1.2.8
done
Checking in public/nsIFeedResult.idl;
/cvsroot/mozilla/toolkit/components/feeds/public/nsIFeedResult.idl,v  <--  nsIFeedResult.idl
new revision: 1.1.2.3; previous revision: 1.1.2.2
done