341035 - Livemark service should delete annotations on livemark delete

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Brett Wilson]

When a livemark is deleted, all the annotations for the items and the folder stay around. This is partially bug 319455 (expire annotations) but the livemark service should do it's annotations explicitly.

Comment 1

[Christine Yen]

Attachment: patch

Not sure whether this is still necessary with bug 319455 almost ready to go, but figured I'd pop in

Comment 2

[Christine Yen]

Plus, currently deleting a folder + undoing the delete loses the folder's annotations - including the description or the livemark's site/feed urls... so the folder's annotations should be saved for sure, anyway.

Comment 3

[Dietrich Ayala (:dietrich)]

Bug 319455 shouldn't matter here, as we should always be cleaning up after ourselves :)

However, I think we want to have this done in the back-end, so that it's consistent for all deletes of all item types in the bookmark system (and it's consumers, such as the microsummary and livemark services).

Comment 4

[Christine Yen]

387952(In reply to comment #2)
> Plus, currently deleting a folder + undoing the delete loses the folder's
> annotations - including the description or the livemark's site/feed urls... so
> the folder's annotations should be saved for sure, anyway.

Reinstantiation of annotations spun off to bug 387952

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch

while investigating on problems with livemark reload i ended up here.

we are checking if a livemark address is in use, but we don't have still removed that, so the check will always return true (and annotations are not deleted). 

As a consequence if i remove a livemark, then readd it back in less then expiration time, it is showed <empty>.

This is bad also because those dangling annos will not let us to delete pages from moz_places (privacy concern).

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 304990 [details] [diff] [review]
patch

good catch, thanks. r=me

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 304990 [details] [diff] [review]
patch

drivers: this fix will help investigating on feed reload problem, and is a privacy concern.

Comment 8

[Damon Sicore (:damons)]

Comment on attachment 304990 [details] [diff] [review]
patch

a1.9+=damons

Comment 9

[Reed Loden [:reed]]

Checking in toolkit/components/places/src/nsLivemarkService.js;
/cvsroot/mozilla/toolkit/components/places/src/nsLivemarkService.js,v  <--  nsLivemarkService.js
new revision: 1.38; previous revision: 1.37
done

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv