387952 - Folder annotations should be kept intact for delete / undo transactions

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Christine Yen]

Attachment: patch

Spun of bug 341035. The old annotations will be deleted in the backend, but "undo" should still retain annotations, or else descriptions/a livemark's feed and site URIs will be lost when the folder is reinstantiated.

Comment 1

[(not reading, please use [e-mail] instead)]

Comment on attachment 272081 [details] [diff] [review]
patch

r=sspitzer

we don't need this line anymore, so I've removed it:

var title = this.bookmarks.getItemTitle(this._id);

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: as checked in

Comment 3

[(not reading, please use [e-mail] instead)]

fixed.

Checking in controller.js;
/cvsroot/mozilla/browser/components/places/content/controller.js,v  <--  control
ler.js
new revision: 1.168; previous revision: 1.167
done

Comment 4

[(not reading, please use [e-mail] instead)]

steps to reprodce:

1) create a new profile
2) open the bookmarks sidebar
3) open the personal toolbar folder in the sidebar
4) select the latest headlines rss feed
5) right click, properties, set a description ("foobar")
5) Edit | Cut
6) Edit | Undo
7) View latest headlines rss feed properites

expected results:  

the item is still feed with the proper feed location, site location and description ("foobar")

Comment 5

[Tracy Walker [:tracy]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007071705 Minefield/3.0a7pre

added test case to litmus : http://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=4456

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv