341369 - Label/Tag colors are not working

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mike Stockman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060612 Minefield/3.0a1
Build Identifier: version 3 alpha 1 (20060612)

Mail that I have already marked with different labels (Important, for example) is no longer showing any color in any mail views.

This happened at the same time that Label disappeared from the Message menu and was replaced by Tag, so perhaps it's related.

(Incidentally, why tag instead of label? Seems like a random change that doesn't add anything.)

Reproducible: Always

Steps to Reproduce:
1. Select a message
2. Right-click and choose a label from the Tag submenu.
3. Notice that the color doesn't change.

Comment 1

[Karsten Düsterloh]

Tags are like labels, just more of them than five. ;-) See bug 114656.

The current CSS is still based on the label properties, which doesn't work yet for keywords/tags. (Fixing this might need backend changes, so probably moving to Core:MailNews backend?)

This bug is visible in SeaMonkey trunk builds also.

Comment 2

[Karsten Düsterloh]

Changes/fixes here should also update the shortcut keys (0-5) which still work and do labels stuff, and the label preference panel!

Comment 3

[Mike Cowperthwaite]

Mike Stockman, is your problem that mails labelled with a previous version aren't displaying with the expected colors, or that it's no longer possible to label a message?  If the former: When you show the Label column in the 3-pane, do you also not see the old label appear in the column for messages you know 
were labelled?

With TB 3a1-0613, Win2K, I see previously labelled messages in the expected colors.  xref bug 114656 comment 122.

Comment 4

[Mike Stockman]

When I display the Labels column, I can see the following:

1) Any message that I labeled "Important" before installing the recent nightly is still labeled Important

2) Anything that I *tag* as Important with current nightlies is also labeled Important

Neither of those messages displays the color that was all-too-recently assigned to the label "Important," and is currently assigned to the tag "Important," which is red.

Is there some set of older files I should delete/recreate in my profile that might be stepping on the color display?

Comment 5

[David :Bienvenu]

Attachment: proposed fix

convert the view backend code to use tag colors, not label colors - but we do migrate the label colors to the corresponding tags, so the user shouldn't be able to tell any difference. I ripped out almost all the label stuff in nsMsgDBView.cpp but I left the pref change observer since I'm not sure if we'll need that going forward...

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 225947 [details] [diff] [review]
proposed fix

sr=sspitzer, acting mailnews superreviewer for mailnews while mscott is away.

one question:  for "rv = aHdr->GetLabel(&label);" should you check the rv?

the exiting nsMsgTagService::GetColorForKey() , zoinks!

Comment 7

[David :Bienvenu]

*** Bug 341879 has been marked as a duplicate of this bug. ***

Comment 8

[David A. Cobb]

David, (or some QA)

I'm running 2006-06-22-04-trunk for Linux.
This is still broken.  Please re-open.

Comment 9

[Mike Cowperthwaite]

(In reply to comment #8)
> I'm running 2006-06-22-04-trunk for Linux.
> This is still broken.  Please re-open.

It's working fine for me with 3a1-0629, Win2K -- if you're still seeing a 
problem under Linux, that's a different bug; please open a new one.