Closed
Bug 341555
Opened 19 years ago
Closed 18 years ago
UI for refreshing a microsummary
Categories
(Firefox Graveyard :: Microsummaries, defect, P2)
Firefox Graveyard
Microsummaries
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 2 beta1
People
(Reporter: myk, Assigned: myk)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
|
15.17 KB,
patch
|
mconnor
:
review+
beltzner
:
ui-review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Users are likely to want to sometimes explicitly update a microsummary, even if the microsummary isn't expired, to ensure they have the most up-to-date summary.
Livemarks includes a "Reload Live Bookmark" item on the context menu for livemark bookmarks which accomplishes this goal. Microsummary bookmarks should have a similar item on their context menus.
| Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Whiteboard: [swag: 0.5d]
Updated•19 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
| Assignee | ||
Comment 1•19 years ago
|
||
This patch adds a "Reload Live Title" item to the context menu for bookmarks with microsummaries. It works exactly like the "Reload Live Bookmark" item on the context menu for livemarks: you select the item from the menu, and then the microsummary service will silently update the microsummary.
Also, as with livemarks:
* the menu item is hidden on context menus for bookmarks that don't have
microsummaries;
* the menu item is present in every bookmark context menu (sidebar, toolbar,
menu, manager)
Note that currently the microsummary won't change when users invoke this command if the current microsummary is the most recent one, in which case users won't get any feedback letting them know they successfully invoked the command.
It seems to me that we should somehow indicate to users that we did indeed do what they asked, even if the result is that nothing changed because the microsummary was already up-to-date. Otherwise they'll wonder whether or not the command worked.
In an earlier conversation in the newsgroup about notifying users when we refresh a microsummary automatically, beltzner said:
> I wonder if we might be able to use something like the Basecamp /
> Wordpress "colour pulse" to draw attention to the fact that something
> has been changed. Both of those applications use JS and CSS to create
> a soft flash of background colour to draw attention to the element
> that's changed (Basecamp uses a soft yellow, for instance) and then
> fades that colour out within a second or so. It might be too much, and
> I worry somewhat about how it will work with alternate themes, but if
> you're really worried that people won't notice. Hm, also, as I think
> about it, that should really only happen if the summary actually
> changes, too. Having a flash for a summary that hasn't changed seems
> pretty useless.
Perhaps we could also apply this strategy to the case where the user manually refreshes the microsummary, except that when they manually refresh we do a colour pulse even if the microsummary didn't change, so they know we did it, whereas when we automatically refresh a microsummary we only pulse if the microsummary did change.
Attachment #225926 -
Flags: ui-review?(beltzner)
Attachment #225926 -
Flags: review?(mconnor)
| Assignee | ||
Updated•19 years ago
|
Priority: -- → P2
Whiteboard: [swag: 0.5d] → [swag: 0.25d]
Comment 2•19 years ago
|
||
Comment on attachment 225926 [details] [diff] [review]
patch v1: adds "Refresh Live Title" context menu item
>+ case "cmd_bm_refreshmicrosummary":
>+ for (i=0; i<length; ++i) {
>+ if (!MICSUMSVC.hasMicrosummary(aSelection.item[i]))
>+ return false;
>+ }
>+ return length > 0;
discussed on IRC with myk, we should offer the context menu option if any of the selected bookmarks have Live Titles
r+a181=me
Attachment #225926 -
Flags: review?(mconnor)
Attachment #225926 -
Flags: review+
Attachment #225926 -
Flags: approval-branch-1.8.1+
| Assignee | ||
Comment 3•19 years ago
|
||
Fix checked in on trunk and 1.8 branch. Leaving bug open pending Places implementation.
Keywords: fixed1.8.1
Comment 4•19 years ago
|
||
I think that this code is necessary.
menulist#name[droppable="false"] > menupopup {display: none;}
Comment 5•19 years ago
|
||
I'm sorry, my spam comment.. It was mistaken for Bug 337825.
Attachment #226295 -
Attachment is obsolete: true
Updated•19 years ago
|
Attachment #225926 -
Flags: ui-review?(beltzner) → ui-review+
| Assignee | ||
Updated•19 years ago
|
Whiteboard: [swag: 0.25d]
| Assignee | ||
Updated•19 years ago
|
Whiteboard: [myk-mss]
| Assignee | ||
Updated•19 years ago
|
Component: Bookmarks → Microsummaries
Whiteboard: [myk-mss]
Updated•19 years ago
|
QA Contact: bookmarks → microsummaries
| Assignee | ||
Comment 6•18 years ago
|
||
This has since been fixed in Places.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•