341686 - imgCache::Init's use of observers is slightly wrong

Status: RESOLVED INVALID

(Core :: Graphics: ImageLib, defect)

Description

[Adam Guthrie]

From IRC:
18:04 <@dbaron> ispiked, it seems like the image cache should probably be owned by whoever's really responsible for owning it; having those observers registered isn't critical to its operation

See also bug 338003 comment 3.

Comment 1

[Stuart Parmenter]

imgCache is an xpcom service and should really be inited as such.  It is also a static class, but the way the observers are hooked up is wrong.

Comment 2

[Alfred Kayser]

Some more comments:
* Init leaks a 'imgCache' object (one is created for the observers but never freed)
* The observers are never removed when the imgCache is shutdown
* ClearCache(bool) is nowhere used except within imgCache itself, so can be removed from IDL?
* Within the Observer, gChromeSession->EvictEntries() can be called directly
* So all three ClearCache variant can then be removed

Comment 3

[Matt Woodrow (:mattwoodrow)]

The imgCache class no longer exists.