341689 - 'Edit Attachment As Comment' converts plain text to HTML entities

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Max Kanat-Alexander]

On the current CVS Bugzilla, if I do "edit attachment as comment" on attachment.cgi, it will take a line line this:

<input>

And convert it to:

&lt;input&gt;

This is particularly irritating when reviewing patches, as you can imagine. For example:

Bugzilla->dbh

becomes:

Bugzilla-&gt;dbh

It's not happening to me on bmo, which is currently running 2.20+. I think it's some change to the attachment/edit.html.tmpl template at some point. I'm looking into it.

Comment 1

[Max Kanat-Alexander]

Okay. I looked into it, and I have no idea why it's happening. If anybody has any idea, please submit a patch and I'll review it. :-)

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

This is a regression due to bug 301764. 2.22 is affected too. My patch applies and has been tested on both 2.22 and tip.

Comment 3

[Frédéric Buclin]

tip:

Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.35; previous revision: 1.34
done

2.22:

Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.30.2.2; previous revision: 1.30.2.1
done