Closed Bug 341888 Opened 19 years ago Closed 19 years ago

document Bookmarks menu -> "Subscribe to This Page[...]"

Categories

(Firefox Graveyard :: Help Documentation, defect)

2.0 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 2

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

(Keywords: fixed1.8.1, late-l10n)

Attachments

(1 file)

Bug 304497 added UI for subscribing to feeds. The Bookmarks menu now shows a "Subscribe to This Page" menu item, which is enabled when there's one feed available. On sites with multiple different feeds, this item is replaced by a "Subscribe to This Page..." menu, which lists the available feeds. While we're here, "Manage Bookmarks..." has been renamed to "Organize Bookmarks...".
Attached patch patchSplinter Review
Actually it's the other way round, the menu item is labelled "Subscribe to This Page..." and the menu "Subscribe to This Page". But that's negligible.
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #226058 - Flags: review?(jwalden+fxhelp)
Target Milestone: Firefox 2 beta2 → Firefox 2 beta1
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2
Keywords: late-l10n
Flags: blocking-firefox2?
Target Milestone: Firefox 2 beta2 → Firefox 2
Flags: blocking-firefox2? → blocking-firefox2+
Comment on attachment 226058 [details] [diff] [review] patch >+ If you have chosen to always subscribe >+ with a Live Bookmark or using a feed reader in the <em>Content</em> panel of >+ &pref.menuPath;, the preview page will be skipped.</p> s/using// My knee-jerk instinct is to document how the item expands to a menu when multiple feeds are available, but I think not mentioning that is the right idea. Most sites only have one feed, and it's not difficult to figure out what happened or how to use the menu UI if it appears. :-)
Attachment #226058 - Flags: review?(jwalden+fxhelp) → review+
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #226058 - Flags: approval1.8.1?
Comment on attachment 226058 [details] [diff] [review] patch a=mconnor on behalf of drivers
Attachment #226058 - Flags: approval1.8.1? → approval1.8.1+
Fixed on branch. >+ If you have chosen to always subscribe >+ with a Live Bookmark or using a feed reader in the <em>Content</em> panel of >+ &pref.menuPath;, the preview page will be skipped.</p> > > s/using// I also did s/subscribe with/subscribe using/ and s/Content/Feeds/ to reflect the latest UI changes. So the sentence reads: If you have chosen to always subscribe using a Live Bookmark or a feed reader in the <em>Feeds</em> panel of &pref.menuPath;, the preview page will be skipped.
Keywords: fixed1.8.1
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: