342237 - disable view-source contextual menu item when viewing binary content

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[philippe (part-time)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a1) Gecko/20060621 Camino/1.2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a1) Gecko/20060621 Camino/1.2+

Bug 309132 disables the menu-item and the keyboard shortcut for 'view-source' when the page/tab only contains binary content. The contextual menu item is still active though, and allows to view source.

Reproducible: Always



Expected Results:  
Contextual menu-item disabled when page only contains binary contents.

Comment 1

[Stuart Morgan]

Attachment: fix

Fix.  Depends on bug 159337.

Comment 2

[Håkan Waara]

Comment on attachment 242468 [details] [diff] [review]
fix

An offtopic point: It'd be nice to see those spellcheck constants moved to an enum in the head of the file instead.

Comment 3

[Stuart Morgan]

Comment on attachment 242468 [details] [diff] [review]
fix

Subject to decision on and landing of bug 159337

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 242468 [details] [diff] [review]
fix

sr=pink

Comment 5

[froodian (Ian Leue)]

Comment on attachment 242468 [details] [diff] [review]
fix

This patch makes context menus that don't have a view source item not display on binary pages.  ie:

1. View an image
2. Try to get the context menu for the image

Comment 6

[froodian (Ian Leue)]

Attachment: fix

The itemWithTarget method just needed an error case in its return statement (this is really smorgan's patch, just spun by me)

Comment 7

[Stuart Morgan]

Comment on attachment 243847 [details] [diff] [review]
fix

Just to dot the i's

Comment 8

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.