Last Comment Bug 342237 - disable view-source contextual menu item when viewing binary content
: disable view-source contextual menu item when viewing binary content
Status: VERIFIED FIXED
: fixed1.8.1.1
Product: Camino Graveyard
Classification: Graveyard
Component: Toolbars & Menus (show other bugs)
: unspecified
: PowerPC Mac OS X
-- normal (vote)
: Camino1.5
Assigned To: Stuart Morgan
:
:
Mentors:
Depends on: 159337
Blocks:
  Show dependency treegraph
 
Reported: 2006-06-20 18:40 PDT by philippe (part-time)
Modified: 2006-10-28 23:20 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
fix (1.30 KB, patch)
2006-10-16 22:20 PDT, Stuart Morgan
hwaara: review+
froodian: review-
mikepinkerton: superreview+
Details | Diff | Splinter Review
fix (2.30 KB, patch)
2006-10-27 15:38 PDT, froodian (Ian Leue)
jaas: superreview+
Details | Diff | Splinter Review

Description User image philippe (part-time) 2006-06-20 18:40:58 PDT
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a1) Gecko/20060621 Camino/1.2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.9a1) Gecko/20060621 Camino/1.2+

Bug 309132 disables the menu-item and the keyboard shortcut for 'view-source' when the page/tab only contains binary content. The contextual menu item is still active though, and allows to view source.

Reproducible: Always



Expected Results:  
Contextual menu-item disabled when page only contains binary contents.
Comment 1 User image Stuart Morgan 2006-10-16 22:20:50 PDT
Created attachment 242468 [details] [diff] [review]
fix

Fix.  Depends on bug 159337.
Comment 2 User image Håkan Waara 2006-10-17 06:20:27 PDT
Comment on attachment 242468 [details] [diff] [review]
fix

An offtopic point: It'd be nice to see those spellcheck constants moved to an enum in the head of the file instead.
Comment 3 User image Stuart Morgan 2006-10-17 07:03:28 PDT
Comment on attachment 242468 [details] [diff] [review]
fix

Subject to decision on and landing of bug 159337
Comment 4 User image Mike Pinkerton (not reading bugmail) 2006-10-25 07:46:23 PDT
Comment on attachment 242468 [details] [diff] [review]
fix

sr=pink
Comment 5 User image froodian (Ian Leue) 2006-10-27 15:23:52 PDT
Comment on attachment 242468 [details] [diff] [review]
fix

This patch makes context menus that don't have a view source item not display on binary pages.  ie:

1. View an image
2. Try to get the context menu for the image
Comment 6 User image froodian (Ian Leue) 2006-10-27 15:38:45 PDT
Created attachment 243847 [details] [diff] [review]
fix

The itemWithTarget method just needed an error case in its return statement (this is really smorgan's patch, just spun by me)
Comment 7 User image Stuart Morgan 2006-10-27 15:45:43 PDT
Comment on attachment 243847 [details] [diff] [review]
fix

Just to dot the i's
Comment 8 User image froodian (Ian Leue) 2006-10-27 16:29:05 PDT
Checked in on 1.8branch and trunk.

Note You need to log in before you can comment on or make changes to this bug.