309132 - Disable view-source when window/tab contains binary content

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Hiro]

The same problem as bug294383 is also in Camino. 
I think that it should view-source disable when image etc. are displayed of 
Camino. 

Reproducible: Always

Mac OS X 10.3.9
2005091722 (v1.0+)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This would also prevent bug 300320 and the like.

Comment 2

[Chris Lawson (gone)]

In reply to Wevah's bug 300320 comment 2, I have a suggestion for how we could
disable the view source consistently:

If the server sends a MIME type that is not text/plain, text/HTML, etc., disable it.

I'm not saying I have any idea how to implement that, exactly. ;)  But that
seems to be a fairly logical way to go about it.

cl

Comment 3

[Chris Lawson (gone)]

Attachment: same approach Firefox took

This uses the same overall approach Gavin used when he fixed this in Firefox. I hope the patch applies, cause it's mildly hand-edited (my tree is dirty from several related bugs). Apologies if it doesn't.

cl

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 226273 [details] [diff] [review]
same approach Firefox took

sr=pink, i'd still like to see a r= as well before it lands.

Comment 5

[Nick Kreeger]

Comment on attachment 226273 [details] [diff] [review]
same approach Firefox took

Looks fine to me, there is a few spacing issues in |isTextBasedContent:| that I will take care of on checkin.

Comment 6

[froodian (Ian Leue)]

fixed on 1.8 branch and trunk.

Comment 7

[philippe (part-time)]

This patch disables the menu-item and associated keyboard shortcut when viewing binary content. However, the contextual menu still contains an *active* view-source menu item. Is this the expected behaviour ?

Comment 8

[Chris Lawson (gone)]

(In reply to comment #7)
> This patch disables the menu-item and associated keyboard shortcut when viewing
> binary content. However, the contextual menu still contains an *active*
> view-source menu item. Is this the expected behaviour ?
 
No. I forgot that one. :-\

File a followup bug, please, and I'll fix that too.

cl

Comment 9

[philippe (part-time)]

D(In reply to comment #8)
> (In reply to comment #7)
> > This patch disables the menu-item and associated keyboard shortcut when viewing
> > binary content. However, the contextual menu still contains an *active*
> > view-source menu item. Is this the expected behaviour ?
> 
> No. I forgot that one. :-\
> 
> File a followup bug, please, and I'll fix that too.

Done: bug 342237.