Closed Bug 342488 Opened 19 years ago Closed 19 years ago

XULRunner nsXULAppInstall.js broken by bug 214672

Categories

(Toolkit Graveyard :: XULRunner, defect)

Product:
Toolkit Graveyard
Component:
XULRunner
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 337558

People

(Reporter: andrew, Unassigned)

References

Details

Attachments

(1 file)

Use the new API
664 bytes, patch
benjamin
: first-review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4 Build Identifier: Trunk XULRunner Bug 214672 changed nsIZipReader, which broke nsXULAppInstall.js in XULRunner. Reproducible: Always Steps to Reproduce: Run xulrunner --install-app app.xpi for any XPI. Actual Results: Get a Javascript error. Expected Results: It installs the application.
Attached patch Use the new API — — Splinter Review
Attachment #226736 - Flags: superreview+
Attachment #226736 - Flags: review+
Attachment #226736 - Flags: superreview?
Attachment #226736 - Flags: superreview+
Attachment #226736 - Flags: review?
Attachment #226736 - Flags: review+
Component: General → XULRunner
Flags: superreview?
Flags: review?
Product: Core → Toolkit
QA Contact: general → xulrunner
You will need to ask someone to review your patch. I would suggest Benjamin Smedberg (:bs in the e-mail field will find him).
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #226736 - Flags: first-review+
Whiteboard: [checkin needed]
Blocks: 214672
This was already covered in bug 337558, complete with patch with r and sr. It only needs someone who can commit it to the tree. *** This bug has been marked as a duplicate of 337558 ***
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE
Whiteboard: [checkin needed]
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: