342762 - [ad-blocking] The new and improved Digg.com shows ads

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Gavin]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060626 Camino/1.0+
Build Identifier: Camino/1.0+

When you browse through digg.com all of the ads are shown (they're Google text ads). This is very annoying.

Reproducible: Always

Steps to Reproduce:
1. Go to Digg.com

Actual Results:  
You see Google ads above and to the side of the digg page

Expected Results:  
Blocked these ads.

 I devised a patch that completely gets rid of them. I believe that since Digg.com is popular, three more lines on the ad_blocking.css file can be integrated into a nightly build. Here are the three lines of CSS:

div[id="top_ad"],
div[id="item_ad"],
div[id="comments_ad"]

I tested it out on my copy of camino, and it seemed to display the page perfectly well.

Comment 1

[Gavin]

Attachment: Updated ad_blocking.css file

This is the adblocking file which I updated to not display Digg.com ads. It worked on my version of Camino. I did not change any other part of Camino to fix the ad problem. In this file, I added three lines:

div[id="top_ad"],
div[id="item_ad"],
div[id="comments_ad"]

Comment 2

[Gavin]

Ok, the update doesn't work perfectly. Sometimes there's a white space right under the digg title bar, and there is a white space to the right of the comments. Also, there's a "deflated" box right next to the comments which used to house the ads and now is empty.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This looks like a good opportunity to use $

div[id$="_ad"],
div.top_ad_image

(the latter to get the flash banner)

Comment 4

[Gavin]

I don't know ANYTHING about the ad_blocking.css file, and just experimented and guessed with what would work. You would know better than me! I'll try out your suggestion though. Thanks for looking into it.

Comment 5

[Gavin]

Attachment: Better version than updated attachment above

Followed your suggestion and it seems perfect. The page that kept showing the flash ad for me, http://digg.com/apple/Apple_execs_to_preview_Leopard_at_WWDC , is fixed now.

Comment 6

[Gavin]

Attachment: Screenshot of a slight annoyance

This is the only part of digg that annoys me now. Is there any way to remove the 'deflated' box? It makes the width of the comments shorter and wastes space, as well as looking ugly. Is there any way to fix this?

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

div[class*="_ad_"]

is probably safe.  It will get rid of the grey outline (and maybe ads elsewhere), but it won't expand the comment width, because the div containing all the comments has a fixed width....

Comment 8

[Gavin]

Attachment: The best version of all (so far)

Ok, your suggestion works. All that I added this time to ad_blocking.css is:

div[class*="_ad_"]

VERY concise!

Comment 9

[Gavin]

I don't know anything about how Bugzilla works, but it's been a while, and nothing has happened. Can someone who knows more about Bugzilla let me know if there's anything I can do to speed up the process of adding the new ad_blocking.css file to Camino? Thanks.

Comment 10

[froodian (Ian Leue)]

Set review flags on your attachment: http://wiki.caminobrowser.org/Development:Reviewing

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Fixed by patch in bug 342956.