[ad-blocking] Block some common/repeat offender imdb flash ads

RESOLVED FIXED in Camino1.5

Status

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: alqahira, Assigned: alqahira)

Tracking

({fixed1.8.1})

unspecified
Camino1.5
PowerPC
macOS
fixed1.8.1
Dependency tree / graph

Details

Attachments

(1 attachment, 2 obsolete attachments)

Fixes bug 342956, bug 342957, bug 342762, bug 341502, and some assorted cleanup I've had in my ad-blocking sticky note for months now.

The object rules are a little more conservative than their corresponding div rules, so the "400" and "171" singletons are missing.  This also won't eliminate all the Flash ads on IMDb, especially not the ones that replace parts of the site navigation when they're displayed.
Attachment #229368 - Flags: review?(bugzilla)
I'll try to remember to check back in with this bug in a few days to move it along  if necessary.
Blocks: 341502, 342762, 342957
Comment on attachment 229368 [details] [diff] [review]
Omnibus ad-blocking patch for July

Looks good to me.

cl
Attachment #229368 - Flags: review?(bugzilla) → review+
Comment on attachment 229368 [details] [diff] [review]
Omnibus ad-blocking patch for July

Simon, can your sr these ad-blocking changes?
Attachment #229368 - Flags: superreview?(sfraser_bugs)
Here are couple more sites which push flash ads:

http://gfx.klipmart.com (seen from ArsTechnica.com)
http://cdn.fastclick.net (seen from Worth1000.com)
Posted patch v2, with klipmart (obsolete) — Splinter Review
sairuh, can you find a specific example of the fastclick ad getting through?  It should be caught by 

embed[type="application/x-shockwave-flash"][src*=".fastclick.net"],

in the current ruleset.  I browsed worth1000 for a bit and didn't see any flash ads at all.

gfx.klipmart.com is a partner of gfx.dvlabs.com, so I've added the former next to the existing rule for the latter.  

Holding off on requesting re-review until we figure out what's up with fastclick.
Attachment #229368 - Attachment is obsolete: true
Attachment #229368 - Flags: superreview?(sfraser_bugs)

Comment 7

13 years ago
I've been seeing a few ads recently that I'd like to block. Here are two:

http://www.eyereturn.com (I forget if this was flash, images or what)
http://a.ads.t-online.de/dat/bgf/200601/10/banner_728x90(1).swf?clickTag=http%3A//re

Can we hold this open for a little longer to accumulate some more sites?
(In reply to comment #7)
> http://a.ads.t-online.de/dat/bgf/200601/10/banner_728x90(1).swf?clickTag=http%3A//re

embed[type="application/x-shockwave-flash"][src*="ads.t-online.de"],
from the existing rules should be blocking that (and does, at least when I load that url directly) :-(

> Can we hold this open for a little longer to accumulate some more sites?

Sure.  A couple of these bugs have been sitting for a while, so I would like to get an update pushed soon-ish (say, by the end of the month) for that reason (as well as to get some baking before nominating for 1.0.3).
Target Milestone: --- → Camino1.1

Comment 10

13 years ago
I just got some heinous flash and image ads from http://media.nyadmcncserve-05y06a.com on the NYT site.
Component: General → Annoyance Blocking
QA Contact: general → annoyance.blocking
This should block everything mentioned so far, plus some ads from torrent.to that people were complaining about in the forum.

Once this lands, I think we can just open a bug for August and start collecting again....
Attachment #229636 - Attachment is obsolete: true
Attachment #231527 - Flags: superreview?(sfraser_bugs)

Updated

13 years ago
Attachment #231527 - Flags: superreview?(sfraser_bugs) → superreview+

Comment 13

13 years ago
Fixed trunk and branch.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Nominating for 1.0.3 so we don't forget after some baking....
Flags: camino1.0.3?
Unified 180branch patch is in bug 348160.
Flags: camino1.0.3?
You need to log in before you can comment on or make changes to this bug.