342816 - seamonkey theme/extension marked as platform: ALL says "not available on Windows" (,MacOS, etc.)

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

https://addons.mozilla.org/developers/listmanager.php?function=editversion&id=2795&vid=17528 shows that it's marked as ALL, but the URL above gives the not-for-this-platform error on all platforms.

Seems to work fine for the Firefox version of the theme, which is also marked ALL.  Not sure what's going on here, can't tell if it's a problem in the database or in the display code so far.

Comment 1

[Wladimir Palant]

That's because AMO doesn't accept SeaMonkey's GUID, it will only display compatibility information for Firefox, Thunderbird and Mozilla Suite.

Comment 2

[Majken Connor [:Kensie]]

is there a bug on that? Seamonkey is a version listed as a target application in the admin pages of, for instance, adblock plus, so clearly there is intent for seamonkey to be supported.

Comment 3

[Philip Chee]

This affects SeaMonkey Only extensions as well:
https://addons.mozilla.org/mozilla/3284/

Comment 4

[Majken Connor [:Kensie]]

I suppose this would be the same bug.  On extensions that are seamonkey compatible, only Firefox is listed.  Adblock plus for example:

https://addons.mozilla.org/mozilla/1865/

Comment 5

[Justin Scott [:fligtar]]

The "not available" message appears because only "supported" applications show download links. Applications are "supported" when they have the applications.supported field set to 1, but this is per application version.

Currently, supported applications are Firefox, Thunderbird, Mozilla, Sunbird
Non-supported: Seamonkey, Flock, Nvu, Netscape

Setting the Seamonkey supported flag to 1 fixes this problem, however I'm not exactly sure how we should go about that. The Application Manager does not reference the supported flag anywhere, and it turns out that the flag was added in v2: http://lxr.mozilla.org/mozilla/source/webtools/addons/shared/sql/v2.sql

It seems that at some point, we added Sunbird as supported, so cc'ing morgamic for advice on how we should add Seamonkey. I don't think we can just execute an SQL command because it wouldn't affect future versions, but I'm not sure how that's working with Firefox/Thunderbird/etc currently either.

Comment 6

[Justin Scott [:fligtar]]

After discussing with morgamic, all we'd need to do is run the following query:
UPDATE applications SET supported=1 WHERE AppName='SeaMonkey';

But, as seen in https://update-staging.mozilla.org/~fligtar/v2/public/htdocs/firefox/220/, we do not have an icon for SeaMonkey. From my rough query, we have 73 add-ons that support SeaMonkey.

This icon needs to be 34x34 and should be placed as public/htdocs/images/seamonkey_icon.png (see http://lxr.mozilla.org/mozilla/source/webtools/addons/public/tpl/addon.tpl#32)

If someone can find an icon for this and attach it, we can resolve this. Thanks!

Comment 7

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: 34x34px icon

Comment 8

[Justin Scott [:fligtar]]

Thanks, Ryan.

The icon has been checked in and is reflected in the above update-staging link.

Shaver: can you approve supporting SeaMonkey, and if so, submit an IT request for the above SQL? (since you will have to approve it there anyway)

Comment 9

[Robert Kaiser]

Ryan, this icon doesn't look quite right, as it misses the white border around the symbolized SeaMonkey animal and it misses the drop shadow that other icons on AMO apparently have as well. Additionally, I can't remember you talking to the SeaMonkey Council about needing an icon for that (even though trademarks are no problem here, as MoFo will own the SeaMonkey trademark once it's registered).
Please, when SeaMonkey artwork is concerned, let it go through my hands as I have all the original imagery on my machine.

Justin: I'll attach a better 34x34 version here, could you please replace it?

Comment 10

[Robert Kaiser]

Attachment: 34x34 SeaMonkey AMO icon

Here's a 34x34 SeaMonkey icon that looks correct and has a drop shadow to fit with other AMO icons, please use that one instead. Thanks!

Comment 11

[Cameron]

Fligtar: what makes you think Sunbird is supported?

eg. see https://addons.mozilla.org/firefox/1330/ and then https://addons.mozilla.org/developers/listmanager.php?function=editversion&id=1330&vid=18150

devCP says it's compatible with Firefox, Flock, Netscape, Nvu, Sunbird and Thunderbird, public site says Firefox & Thunderbird.

So if Sunbird has this "supported" flag, it's not working as you say it will for Seamonkey.

Next up, if we add seamonkey as a supported app now, what are we going to do about the app name stuff in the url, header, links, etc. ?

Comment 12

[Robert Kaiser]

It would be good to see SeaMonkey fully supported (same for Sunbird and Camino though) on AMO. If that's where we can and want to go, I'd be happy to provide any bits of artwork needed.
I realized the icon here is in the main mozilla.org CVS, if any further SeaMonkey artwork is needed, I know the right file names and it's approved by someone who can speak for AMO project, I also can check in that myself when wanted/needed.

Comment 13

[Justin Scott [:fligtar]]

Cameron: Yeah, I realized last night that apparently I made Sunbird supported in my own v2 install and didn't remember doing so, it's not supported... although morgamic said it probably should be.

About the banners and such, I wasn't planning on creating a whole new section of the site for this, I just want Seamonkey-only add-ons to be able to be downloaded. I don't think having it on the list of supported apps means it HAS to have its own section. 

Robert: I was told clouserw had already requested a Seamonkey icon and never got one, but if I ever come across a similar issue I will come to you. Checking the new icon in now.

Comment 14

[Robert Kaiser]

(In reply to comment #13)
> Robert: I was told clouserw had already requested a Seamonkey icon and never
> got one, but if I ever come across a similar issue I will come to you. Checking
> the new icon in now.

OK, in case any other SeaMonkey artwork is needed somewhere, you can tell people to contact seamonkey-council@m.o or me directly with the needed format and the purpose for what the artwork is to be used and I will try to come up with whatever needed as possible.

Comment 15

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

(In reply to comment #8)
> Shaver: can you approve supporting SeaMonkey, and if so, submit an IT request
> for the above SQL? (since you will have to approve it there anyway)

Apologies for not replying to this sooner -- I'm running quite a lag on my bugmail, and didn't see that my opinion was being sought here until fligtar poked me in IRC.

I do think that, in the general case, AMO should support seamonkey extensions (after all, I filed the bug!).  I don't think that we should spend cycles on this issue now, or other v1/v2 issues that aren't service-breaking or security-related, in favour of focusing on getting Remora out the door.

Seamonkey and Sunbird and other folks who want to help make Remora work well with their apps are heartily welcomed to check out the current bits and do some foundational work on parts of the app that will need to become aware of such things.  (The schema and core are capable of handling various apps, but things like how to visualize compatibility information, esp. for non-browser apps, will need some work.)  Test cases here would be especially welcome, even in advance of the code and template work supporting it.

Comment 16

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Sooooo....

(In reply to comment #15)
> I do think that, in the general case, AMO should support seamonkey extensions
> (after all, I filed the bug!).  I don't think that we should spend cycles on
> this issue now, or other v1/v2 issues that aren't service-breaking or
> security-related, in favour of focusing on getting Remora out the door.

I've been thinking more about this, and since confidence is high that this SQL change (and the requisite live-update push) will let people install these extensions, I'm going to go ahead and get those pieces done.

> Seamonkey and Sunbird and other folks who want to help make Remora work well
> with their apps are heartily welcomed to check out the current bits and do some
> foundational work on parts of the app that will need to become aware of such
> things.]

This stands, more than ever!

Comment 17

[Michael Morgan [:morgamic]]

Attachment: SQL to update supported applications.

SQL to update supported apps in applications table.

Comment 18

[Justin Scott [:fligtar]]

Comment on attachment 239205 [details]
SQL to update supported applications.

r=fligtar

Comment 19

[Michael Morgan [:morgamic]]

Icon added earlier, and SQL will update the SeaMonkey app shortly.

Comment 20

[Justin Scott [:fligtar]]

https://addons.mozilla.org/firefox/2795/ now displays the icon and is downloadable.

Comment 21

[Philip Chee]

Extensions are also downloadable
https://addons.mozilla.org/firefox/3284/
Thanks.