Closed
Bug 342861
Opened 19 years ago
Closed 19 years ago
Cannot upgrade from any version before 2.17.1.
Categories
(Bugzilla :: Installation & Upgrading, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: mkanat, Assigned: LpSolit)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.31 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
When upgrading from any version before 2.17.1, checksetup.pl dies with:
> checksetup.pl: DBD::mysql::db selectcol_arrayref failed: Unknown column 'id' in 'field list' [for Statement "SELECT id FROM groups
> checksetup.pl: ORDER BY isbuggroup, name"] at Bugzilla/Group.pm line 132
> checksetup.pl: Bugzilla::Group::get_all_groups() called at Bugzilla/Config/GroupSecurity.pm line 44
> checksetup.pl: Bugzilla::Config::GroupSecurity::get_param_list('Bugzilla::Config::GroupSecurity') called at Bugzilla/Config.pm line 118
> checksetup.pl: Bugzilla::Config::_load_params() called at Bugzilla/Config.pm line 241
> checksetup.pl: Bugzilla::Config::UpdateParams() called at ./checksetup.pl line 1357
I think we should find a way to have those functions only run when the defaults are really needed, which is very rarely. I think that might involve some rearchitecture of Bugzilla::Config stuff, which would be fine by me.
Reporter | ||
Comment 1•19 years ago
|
||
Actually, I mean something different. :-) I mean we should have a way to get only the defaults for params, and nothing else. That sould solve this problem, definitely.
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee | ||
Comment 2•19 years ago
|
||
I checked that checksetup.pl doesn't try to access group names and that these group names are only called when viewing editparams.cgi?section=groupsecurity.
The downside with this patch is that Bugzilla::Group::get_all_groups() is called once per parameter requiring group names, i.e. 3 times. But as it's only called when viewing this section in editparams.cgi, maybe that's not such a high load.
Attachment #228045 -
Flags: review?(mkanat)
Reporter | ||
Comment 3•19 years ago
|
||
Comment on attachment 228045 [details] [diff] [review]
patch, v1
Yep. I wrote a patch that does basically exactly this, also. :-)
Attachment #228045 -
Flags: review?(mkanat) → review+
Assignee | ||
Updated•19 years ago
|
Flags: approval?
Updated•19 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 4•19 years ago
|
||
Checking in Bugzilla/Config/GroupSecurity.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/GroupSecurity.pm,v <-- GroupSecurity.pm
new revision: 1.5; previous revision: 1.4
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•