342861 - Cannot upgrade from any version before 2.17.1.

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P1)

Description

[Max Kanat-Alexander]

When upgrading from any version before 2.17.1, checksetup.pl dies with:

> checksetup.pl: DBD::mysql::db selectcol_arrayref failed: Unknown column 'id' in 'field list' [for Statement "SELECT id FROM groups
> checksetup.pl:                                               ORDER BY isbuggroup, name"] at Bugzilla/Group.pm line 132
> checksetup.pl: 	Bugzilla::Group::get_all_groups() called at Bugzilla/Config/GroupSecurity.pm line 44
> checksetup.pl: 	Bugzilla::Config::GroupSecurity::get_param_list('Bugzilla::Config::GroupSecurity') called at Bugzilla/Config.pm line 118
> checksetup.pl: 	Bugzilla::Config::_load_params() called at Bugzilla/Config.pm line 241
> checksetup.pl: 	Bugzilla::Config::UpdateParams() called at ./checksetup.pl line 1357

I think we should find a way to have those functions only run when the defaults are really needed, which is very rarely. I think that might involve some rearchitecture of Bugzilla::Config stuff, which would be fine by me.

Comment 1

[Max Kanat-Alexander]

Actually, I mean something different. :-) I mean we should have a way to get only the defaults for params, and nothing else. That sould solve this problem, definitely.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

I checked that checksetup.pl doesn't try to access group names and that these group names are only called when viewing editparams.cgi?section=groupsecurity.

The downside with this patch is that Bugzilla::Group::get_all_groups() is called once per parameter requiring group names, i.e. 3 times. But as it's only called when viewing this section in editparams.cgi, maybe that's not such a high load.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 228045 [details] [diff] [review]
patch, v1

Yep. I wrote a patch that does basically exactly this, also. :-)

Comment 4

[Frédéric Buclin]

Checking in Bugzilla/Config/GroupSecurity.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/GroupSecurity.pm,v  <--  GroupSecurity.pm
new revision: 1.5; previous revision: 1.4
done