don't recheck microsummaries when previous updates fail until normal expiration

RESOLVED FIXED in Firefox 2 beta1

Status

Firefox Graveyard
Microsummaries
RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

({fixed1.8.1})

Trunk
Firefox 2 beta1
fixed1.8.1
Bug Flags:
blocking-firefox2 +

Details

Attachments

(1 attachment)

839 bytes, patch
Ben Goodger (use ben at mozilla dot org for email)
: review+
Darin Fisher
: approval1.8.1+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
If the microsummary service attempts to update a microsummary, and the update attempt fails, the service tries again in 15 seconds, which means that if the failure occurred during or after the generator/page was requested, and the failure is persistent, then the service will repeatedly issue requests every 15 seconds, possibly inadvertently DOSing the server and exacerbating any load/availability problems it is experiencing.

The microsummary service should never attempt to update a microsummary more frequently than the default interval.  This should be easy to fix.  We just need to make the service reset the microsummary's expiration property before it starts the update instead of after the update completes.  But making this depend on bug 339543, as this probably involves touching code that bug is changing.
(Assignee)

Updated

12 years ago
Flags: blocking-firefox2?

Updated

12 years ago
Flags: blocking-firefox2? → blocking-firefox2+
(Assignee)

Comment 1

12 years ago
Created attachment 228121 [details] [diff] [review]
patch v1: the minimal fix for this bug

Here's the minimal fix for this bug.  It updates the expiration time before trying to refresh the microsummary during the regular updateMicrosummaries cycle.  But it doesn't yet remove the code that updates the expiration time after the microsummary is refreshed.

We should move that code so that it only runs when microsummaries are manually refreshed (i.e. not during the regular update cycle, but because of some user action), but perhaps we can do that in a separate patch.
Attachment #228121 - Flags: review?(bugs)
Comment on attachment 228121 [details] [diff] [review]
patch v1: the minimal fix for this bug

r=ben@mozilla.org
Attachment #228121 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

12 years ago
Fix checked in to trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 4

12 years ago
Comment on attachment 228121 [details] [diff] [review]
patch v1: the minimal fix for this bug

a=darin on behalf of drivers
Attachment #228121 - Flags: approval1.8.1+
(Assignee)

Updated

12 years ago
Keywords: fixed1.8.1
(Assignee)

Updated

12 years ago
Component: Bookmarks → Microsummaries
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.