342943 - Evaluate localization of feed contentHandler webservices

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Axel Hecht [:Pike]]

http://lxr.mozilla.org/mozilla1.8/source/browser/app/profile/firefox.js#448

lists a few webservices to handle feeds, we may want those to be localizable.

Comment 1

[Pavel Franc - Mozilla.cz]

This could be IMHO localizable by adding appropriate prefs into firefox-l10n.js and I surely want to substitute the english services with our local ones.

Comment 2

[Axel Hecht [:Pike]]

firefox-l10n.js sounds like the least favorable position for critical l10n content, from a trademarks and QA perspective.

Comment 3

[Phil Schwan]

Just so we're totally clear -- because earlier comments say "may" and "could" -- we definitely want the feed services to be localizable for Firefox 2.

As far as I know, everyone is in agreement that this fix should go into beta2; speak now if you dissent!

Comment 4

[Gen Kanai [:gen]]

I'm collecting the Japanese market services.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Uses localizable strings for service names and URIs, also updates the name of the Google services to the correct production names.

Comment 6

[Axel Hecht [:Pike]]

Is the number of three feeds per locale given? Could they add more, or drop one?

I'm curious about those
pref("browser.contentHandlers.types.2.type", "application/vnd.mozilla.maybe.feed");
is it a good idea to hardcode those in firefox.js, or would it make sense to fallback to "application/vnd.mozilla.maybe.feed" if that's not given at all?

One nit, the XXBen comment should probably go as part of fixing this bug.

Comment 7

[Phil Schwan]

(In reply to comment #6)
> Is the number of three feeds per locale given? Could they add more, or drop
> one?

Three is not a firm limit.  If there aren't three that make sense for a given locale, then having fewer seems reasonable.  If there are four or five that have a legitimate strong presence in that market, then they shouldn't hesitate to submit them for approval.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

The type is necessary because the system that handles web service registration for content types is not specific in any way to feeds, feeds just happens to be the first consumer of its data. 

Comment 9

[Pam Greene]

Comment on attachment 230156 [details] [diff] [review]
patch

>Index: browser/app/profile/firefox.js

> #ifdef MOZ_FEEDS
> // XXXben This is just here for demo purposes until web registration works!
> // XXXben Needs Localization!

Nit: this second comment isn't needed anymore.  (Does the first still apply?)

r=me with inapplicable comments nixed.

Comment 10

[Gen Kanai [:gen]]

Pam- question for the Japan market.  Do you want the same URL or is there a google.co.jp url that we should be using for the Japan builds?

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed on trunk. 

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed on the branch. 

When this service becomes truly generic for FF3.0, the type field needs to become localizable too, and perhaps this configuration should no longer live in prefs?

Comment 13

[Phil Schwan]

Axel: Now that this has landed, can you write a quick paragraph that describes exactly what people need to do to change these values in their locale?  You can drop it right into the l10n-requirements if you want, or stick it here, or email me, whatever's easiest.

Comment 14

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #7)
> If there are four or five that
> have a legitimate strong presence in that market, then they shouldn't hesitate
> to submit them for approval.

I was playing around with this a moment ago and when I added:

browser.contentHandlers.types.3.title=Startowy.com
browser.contentHandlers.types.3.uri=http://www.startowy.com/dodajrss.html?zrodlo=%s

to the region.properties, it did not show up. When I removed Yahoo and added it as ...types.2 it appeared correctly.

Then I read the patch above and now it's clear to me that .3 can't work from region.properties. 

It's not that I want more than three in my locale, though.