Closed Bug 343353 Opened 18 years ago Closed 18 years ago

Download source tooltips aren't restored on launch

Categories

(Camino Graveyard :: Downloading, defect)

Product:
Camino Graveyard
Component:
Downloading
Version:
1.8 Branch
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: stuart.morgan+bugzilla, Assigned: froodian)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Calls setSourceURL
1.18 KB, patch
stuart.morgan+bugzilla
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
Downloads saved across browser launches don't have their source tooltips restored. It looks like the problem is just that setProgressViewFromDictionary: assigns directly to mSourceURL instead of calling setSourceURL:.  Should be a one-line fix.
Assignee: nobody → stridey
Status: NEW → ASSIGNED

        Attachment #227868 -
        Flags: review?(stuart.morgan)

    
    

    
  
Comment on attachment 227868 [details] [diff] [review]
Calls setSourceURL

r=me

        Attachment #227868 -
        Flags: superreview?(mikepinkerton)

        Attachment #227868 -
        Flags: review?(stuart.morgan)

        Attachment #227868 -
        Flags: review+

    
    

    
  
Comment on attachment 227868 [details] [diff] [review]
Calls setSourceURL

sr=pink

        Attachment #227868 -
        Flags: superreview?(mikepinkerton) → superreview+

    
  
Whiteboard: [needs checkin]

    
    

    
  
Fixed trunk and branch
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]

    
    

    
  
This the broken tooltips bug for downloads? I have a recent version (Version 2007092000 (1.6a1pre)) and it still shows broken tooltips.

    
    

    
  
You probably want bug 318629. This was specifically about the problem described in comment 0, and was fixed.

    
    

    
  
No, because this one refers to here in comment #8. I still get wrong tooltips (or maybe again). I haven't figured out though what pattern causes the wrong tooltips. Shall I open a new bug for this?

    
    

    
  
It refers to here specifically for the part quoted in that comment, which was separate from the rest of the issue. That bug is about the tooltips being incorrect, and it is still open, so no, you should not open a new bug.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.