Closed
Bug 343360
Opened 18 years ago
Closed 18 years ago
FileWriter's security check doesn't work with flat chrome
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect)
Firefox Graveyard
RSS Discovery and Preview
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 3 alpha1
People
(Reporter: asqueella, Assigned: asqueella)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
|
1.39 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
When you build with --enable-chrome-format=flat, feeds subscription dialog is broken due to FileWriter._isValidWindow function checking that the real URL of the page called into it starts with "jar:file://", which is obviously not true for a app built with flat chrome.
I'm going to change that check to a more restrictive, but at the same time more correct: check that the real URI of the page equals the resolved URI returned by the chrome registry for the subscription page (chrome://browser/content/feeds/subscribe.xhtml)
|
Assignee | |
Comment 1•18 years ago
|
||
|
||
Comment 2•18 years ago
|
||
Comment on attachment 227840 [details] [diff] [review]
patch
Please use Cc and Ci and the indentation style used elsewhere in this file.
If you can do that, and attach a new patch I'll check it in. This looks good. We might want to get this for b2 too if we can (since I think your approach is superior to mine).
Attachment #227840 -
Flags: review?(bugs) → review-
|
|
Assignee | |
Comment 3•18 years ago
|
||
Attachment #227840 -
Attachment is obsolete: true
Attachment #230186 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 4•18 years ago
|
||
Setting target milestone to b2 per ben's comment.
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Firefox 2 beta2
|
|
Assignee | |
Comment 5•18 years ago
|
||
Attachment #230186 -
Attachment is obsolete: true
Attachment #235507 -
Flags: review?(bugs)
Attachment #230186 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•18 years ago
|
Target Milestone: Firefox 2 beta2 → Firefox 2
|
||
Updated•18 years ago
|
Version: Trunk → 2.0 Branch
|
|
Assignee | |
Comment 6•18 years ago
|
||
*** Bug 351726 has been marked as a duplicate of this bug. ***
|
||
Comment 7•18 years ago
|
||
*** Bug 352648 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Updated•18 years ago
|
Target Milestone: Firefox 2 → Firefox 3 alpha1
Version: 2.0 Branch → Trunk
|
|
Assignee | |
Updated•18 years ago
|
Attachment #235507 -
Flags: review?(bugs) → review?(gavin.sharp)
|
||
Updated•18 years ago
|
Attachment #235507 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [checkin needed]
|
|
||
Comment 8•18 years ago
|
||
mozilla/browser/components/feeds/src/FeedWriter.js 1.20
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
See Also: → https://launchpad.net/bugs/61182
|
||
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•