343532 - Spellchecker crashes when deleting content in gmail message body [@ FindNextNode]

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Simon Montagu :smontagu]

Steps to reproduce:

Compose mail in gmail
Enter a single character in the message body
Delete it

This is the top of the stack:
#0  0x40e1fc7d in FindNextNode ()
   from /home/simon/mozwork/ff/mozilla/obj-ff-opt/dist/bin/components/libspellchecker.so
#1  0x40e20c5e in mozInlineSpellWordUtil::BuildSoftText ()
   from /home/simon/mozwork/ff/mozilla/obj-ff-opt/dist/bin/components/libspellchecker.so
#2  0x40e1ff24 in mozInlineSpellWordUtil::EnsureWords ()
   from /home/simon/mozwork/ff/mozilla/obj-ff-opt/dist/bin/components/libspellchecker.so
#3  0x40e20024 in mozInlineSpellWordUtil::GetRangeForWord ()
   from /home/simon/mozwork/ff/mozilla/obj-ff-opt/dist/bin/components/libspellchecker.so
#4  0x40e1c540 in mozInlineSpellChecker::SpellCheckAfterEditorChange ()
   from /home/simon/mozwork/ff/mozilla/obj-ff-opt/dist/bin/components/libspellchecker.so
#5  0x08744a71 in nsEditor::HandleInlineSpellCheck ()
#6  0x086f6b3d in nsHTMLEditRules::AfterEditInner ()
#7  0x086f66a5 in nsHTMLEditRules::AfterEdit ()
#8  0x086e8d46 in nsHTMLEditor::EndOperation ()
#9  0x08730cab in nsPlaintextEditor::DeleteSelection ()
#10 0x08737316 in nsTextEditorKeyListener::KeyPress ()

Comment 1

[Frank Wein [:mcsmurf]]

Regression from Bug 339066.

Comment 2

[Adam Guthrie]

This still happens even with roc's patch that fixed the balsa bustage?

Comment 3

[Simon Montagu :smontagu]

Yes, I have that patch in my tree and it still happens

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Simple fix ... we need to stop earlier when looking for the next node, when aNode is the root node and has no children --- before we look for siblings or try to navigate upwards.

Comment 5

[Scott MacGregor]

Comment on attachment 228078 [details] [diff] [review]
fix

thanks Roc.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I landed the fix for this along with the rest of the fix for bug 339066 on the 1.8.1 branch.

Comment 8

[Adam Guthrie]

*** Bug 343748 has been marked as a duplicate of this bug. ***

Comment 9

[Adam Guthrie]

*** Bug 343742 has been marked as a duplicate of this bug. ***

Comment 10

[Adam Guthrie]

*** Bug 343656 has been marked as a duplicate of this bug. ***

Comment 11

[Marcia Knous [:marcia]]

verified on the 1.8 branch using the Thunderbird Linux candidate build, version 2.0.0.0 (20070326). I followed the STR in Simon's initial report. Adding verified keyword.