Closed
Bug 343766
Opened 18 years ago
Closed 18 years ago
localize anti-phishing reporting urls
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: tony, Assigned: tony)
Details
(Keywords: fixed1.8.1)
Attachments
(2 files, 1 obsolete file)
6.63 KB,
patch
|
mmc
:
review+
bryner
:
superreview+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
7.74 KB,
patch
|
Details | Diff | Splinter Review |
Anti-phishing data providers must provide a URL to a report phishing page (see bug 339876). In particular, up to three URLs are provided: reportGenericURL, reportErrorURL, and reportPhishURL. These need to be localized to the users language. We can use {moz:locale} like search plugins do and replace that.
Assignee | ||
Updated•18 years ago
|
Flags: blocking-firefox2?
OS: Linux → All
Hardware: PC → All
Comment 1•18 years ago
|
||
This bug should depend on bug 339876, but since that one isn't blocking yet, this one won't be.
Depends on: 339876
Flags: blocking-firefox2? → blocking-firefox2-
Assignee | ||
Updated•18 years ago
|
Target Milestone: --- → Firefox 2 beta2
Assignee | ||
Comment 2•18 years ago
|
||
The changes to browser/app/profile/firefox.js is just to demonstrate how this works. I realize the final urls will be different.
Attachment #229173 -
Flags: review?(mmchew)
Comment 3•18 years ago
|
||
Comment on attachment 229173 [details] [diff] [review] v1: use {moz:locale} for locale This looks fine to me.
Attachment #229173 -
Flags: review?(mmchew) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #229173 -
Flags: superreview?(bryner)
Comment 4•18 years ago
|
||
Comment on attachment 229173 [details] [diff] [review] v1: use {moz:locale} for locale Can you just use @AB_CD@, or do you need these URLs to change if general.useragent.locale is changed after install?
Assignee | ||
Comment 5•18 years ago
|
||
(In reply to comment #4) > (From update of attachment 229173 [details] [diff] [review] [edit]) > Can you just use @AB_CD@, or do you need these URLs to change if > general.useragent.locale is changed after install? I think it'd be better if it changed when the user changes locales. That said, there ought to be a pref observer for general.useragent.locale so it does actually update without a restart. I'll cut a new patch.
Assignee | ||
Comment 6•18 years ago
|
||
Same as v1 patch + pref observer for locale change.
Attachment #229173 -
Attachment is obsolete: true
Attachment #229508 -
Flags: superreview?(bryner)
Attachment #229173 -
Flags: superreview?(bryner)
Comment 7•18 years ago
|
||
Comment on attachment 229173 [details] [diff] [review] v1: use {moz:locale} for locale lets go with this one
Attachment #229173 -
Attachment is obsolete: false
Attachment #229173 -
Flags: superreview+
Updated•18 years ago
|
Attachment #229508 -
Attachment is obsolete: true
Attachment #229508 -
Flags: superreview?(bryner)
Assignee | ||
Comment 8•18 years ago
|
||
on trunk
Assignee | ||
Updated•18 years ago
|
Attachment #229173 -
Flags: approval1.8.1?
Assignee | ||
Updated•18 years ago
|
Flags: blocking-firefox2- → blocking-firefox2?
Comment 9•18 years ago
|
||
Comment on attachment 229173 [details] [diff] [review] v1: use {moz:locale} for locale a=drivers. Please go ahead and land on the branch. Why isn't the trunk also pointing to mozilla.org, btw?
Attachment #229173 -
Flags: approval1.8.1? → approval1.8.1+
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Assignee | ||
Comment 10•18 years ago
|
||
(In reply to comment #9) > (From update of attachment 229173 [details] [diff] [review] [edit]) > a=drivers. Please go ahead and land on the branch. > > Why isn't the trunk also pointing to mozilla.org, btw? I didn't apply bug 344063 to trunk. I can change the urls in this patch if you want trunk to point to the bonecho urls that we're using on branch (http://www.mozilla.org/projects/bonecho/anti-phishing/report_general/, etc).
Assignee | ||
Comment 11•18 years ago
|
||
on branch
Status: NEW → RESOLVED
Closed: 18 years ago
No longer depends on: 339876
Keywords: fixed1.8.1
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•