344063 - report phishing page should include the mozilla brand

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Tony Chang (Google)]

> > > When I select "Report a Phishing Website" from the Help menu, we end up
> > > here:                                                                  
> > > 
> > > http://www.google.com/safebrowsing/report_phish/
> > > 
> > > There's an urgent desire to have the page that we land at Mozilla
> > > co-branded w/ Google.

Comment 1

[Tony Chang (Google)]

Attachment: v1: add client id in report phish url

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

blocking so we can triage it for today's respins

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: changes report URLs to pages on mozilla.org

Spoke with Chris Beard and he'd rather the URLs point to mozilla.org to start with, and have those pages either use iframes or links to go over to the google pages. Changed the patch so that it uses:

http://www.mozilla.org/projects/bonecho/anti-phishing/report_general/
http://www.mozilla.org/projects/bonecho/anti-phishing/report_error/
http://www.mozilla.org/projects/bonecho/anti-phishing/report_phish/

Chris says this blocks b1

Comment 4

[Tony Chang (Google)]

(In reply to comment #3)
> Created an attachment (id=228688) [edit]
> changes report URLs to pages on mozilla.org
> 
> Spoke with Chris Beard and he'd rather the URLs point to mozilla.org to start
> with, and have those pages either use iframes or links to go over to the google
> pages. Changed the patch so that it uses:
> 
> http://www.mozilla.org/projects/bonecho/anti-phishing/report_general/
> http://www.mozilla.org/projects/bonecho/anti-phishing/report_error/
> http://www.mozilla.org/projects/bonecho/anti-phishing/report_phish/

Ok, iframes or links should work fine.  Will we be using the urls in the previous patch (i.e., adding the client url parameter)?  We need to make changes to the server to support this.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Oh, poop, yes, we should pass along the other parameters. Can you please whip up a patch that includes them?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Or wait, I think this patch will still automatically append them?

Comment 7

[Chris Beard]

Let's use links from a mozilla.org hosted web page, aspirationally with .js to set and pass parameters to prepopulate form fields.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

The Report a Phishing site yields ..:

http://www.mozilla.org/projects/bonecho/anti-phishing/report_phish/&hl=en-US&url=http%3A%2F%2Fwww.google.com%2Ftools%2Ffirefox%2Fsafebrowsing%2Fphish-o-rama.html

The [send report] link in the bubble yeilds ..:

http://www.mozilla.org/projects/bonecho/anti-phishing/report_general/&url=http%3A%2F%2Fwww.google.com%2Ftools%2Ffirefox%2Fsafebrowsing%2Fphish-o-rama.html

The "let us know" link in the bubble yeilds ..:

http://www.mozilla.org/projects/bonecho/anti-phishing/report_error/&url=http%3A%2F%2Fwww.google.com%2Ftools%2Ffirefox%2Fsafebrowsing%2Fphish-o-rama.html

So I think we're good to go.

Comment 9

[Tony Chang (Google)]

(In reply to comment #3)
> Created an attachment (id=228688) [edit]
> changes report URLs to pages on mozilla.org

Landed on 181 branch.  I added a ? to the end of the urls so appending params doesn't send it to a different directory.  These urls will change when we localize properly (bug 343766).

Comment 10

[alice nodelman [:alice] [:anode]]

verified on mac os x, 10.4.6

matches the behavior in comment #8

link from 'report phish'
http://www.mozilla.org/projects/bonecho/anti-phishing/report_phish/?&hl=en-US&url=http%3A%2F%2Fwww.google.com%2Ftools%2Ffirefox%2Fsafebrowsing%2Fphish-o-rama.html
link from 'send report'
http://www.mozilla.org/projects/bonecho/anti-phishing/report_general/?&url=http%3A%2F%2Fwww.google.com%2Ftools%2Ffirefox%2Fsafebrowsing%2Fphish-o-rama.html
link from 'let us know'
http://www.mozilla.org/projects/bonecho/anti-phishing/report_error/?&url=http%3A%2F%2Fwww.google.com%2Ftools%2Ffirefox%2Fsafebrowsing%2Fphish-o-rama.html

Comment 11

[Bill Gianopoulos [:WG9s]]

Well the current behavior is worse.  There is an extra Mozilla branded page before you get to the actual report the phishing scam page.  Clicking on the report this site as phishing link on that page takes you to the Google report a site page, but the URL is no longer filled in.

Presumably this will all be sorted before the release?

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Marking this one fixed. Filed bug 344551 for follow up issues.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This doesn't seem to have landed on the trunk.

Comment 14

[Tony Chang (Google)]

Do we want minefield to point to bonecho pages?  Someone say "yes" and I'll go ahead and land on trunk.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Yeah, I'm OK with that for now. The final plan will be to have all users of the safebrowsing service pointing to mozilla.com pages ...

Comment 16

[Tony Chang (Google)]

on trunk

Comment 17

[Sherman Dickman]

Tony, can we reopen this bug?  

Comment 18

[Tony Chang (Google)]

(In reply to comment #17)
> Tony, can we reopen this bug?  

Maybe we can just use bug 346242 to track what needs to be done with regards to the report phishing pages?

Comment 19

[Sherman Dickman]

That works.  Thanks!