343810 - Remove Bugzilla::FlagType::get() and implement real flagtype objects

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Frédéric Buclin]

Similar to bug 343432, but for flagtypes. Should be pretty trivial as almost nothing uses flagtypes. ;)

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Not as trivial as I first thought, due to editflagtypes.cgi and the numerous "hacks" it contains. This patch requires the one from bug 174039, as well as the one from bug 345032 if you don't want to crash when testing request.cgi. Have fun!

Comment 2

[Frédéric Buclin]

Big patch, but I feel pretty confident with it and I'm available to fix any regression which would arise.

Comment 3

[Frédéric Buclin]

Comment on attachment 229653 [details] [diff] [review]
patch, v1

no review required

Comment 4

[Frédéric Buclin]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.118; previous revision: 1.117
done
Checking in editflagtypes.cgi;
/cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v  <--  editflagtypes.cgi
new revision: 1.43; previous revision: 1.42
done
Checking in importxml.pl;
/cvsroot/mozilla/webtools/bugzilla/importxml.pl,v  <--  importxml.pl
new revision: 1.64; previous revision: 1.63
done
Checking in request.cgi;
/cvsroot/mozilla/webtools/bugzilla/request.cgi,v  <--  request.cgi
new revision: 1.37; previous revision: 1.36
done
Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.71; previous revision: 1.70
done
Checking in Bugzilla/FlagType.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/FlagType.pm,v  <--  FlagType.pm
new revision: 1.33; previous revision: 1.32
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.121; previous revision: 1.120
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.75; previous revision: 1.74
done
Checking in template/en/default/admin/flag-type/confirm-delete.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/confirm-delete.html.tmpl,v  <--  confirm-delete.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.19; previous revision: 1.18
done
Checking in template/en/default/admin/flag-type/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v  <--  code-error.html.tmpl
new revision: 1.73; previous revision: 1.72
done