343820 - Add-ons app upgrade compatibility wizard needs some branding.

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

See bug 339526 and 341697 for background info.

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Comment 2

[Robert Strong (they/them - no direct email)]

Ryan, this will have to wait on bug 341697 being fixed but otherwise it should work. I'll review after sspitzer fixes bug 341697.

Comment 3

[(not reading, please use [e-mail] instead)]

ryan, that patch looks good to me, but as robert points out, you'll need bug #341697 fixed first.

I'll re-assign to me so that I take this when I fix #341697 on trunk and branch for beta 2.

Comment 4

[(not reading, please use [e-mail] instead)]

I've tested this fix, and it works.

screen shot coming.

I think we want this for ff 2.0 just as we wanted bug #339526

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: branded add-on wizard

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 228382 [details] [diff] [review]
Patch

r=sspitzer

Comment 7

[(not reading, please use [e-mail] instead)]

thanks to ryan for this patch, and for robert for logging the bug.

I hope to land this for ff 2.0 b2 when I land bug #341697

Comment 8

[(not reading, please use [e-mail] instead)]

fixed on the trunk.

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 228382 [details] [diff] [review]
Patch

also seeking a= for the 1.8 branch

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 228382 [details] [diff] [review]
Patch

Looks great. This should help keep users from getting confused. Do we also have a branded import profile wizard?

Comment 11

[(not reading, please use [e-mail] instead)]

> Do we also have a branded import profile wizard?

yes, that wizard is also branded (see bug #341697)

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 228382 [details] [diff] [review]
Patch

a=drivers on the 181branch

Comment 13

[(not reading, please use [e-mail] instead)]

fixed on branch.