Seen in Camino 1.0.2 (localized) Go to https://cacert.org The button to not do anything at all is labelled "Stop"? I think this would be less confusing as "Cancel", like other dialogs of the same kind.
Given the query in the dialog, I think "Stop" makes sense, but you raise a good point in that users probably don't read dialog boxes as carefully as they should. cl
We could probably fit "Don’t Connect" in there, which would be a bit better than "Stop" and much more-so than "Cancel".
Created attachment 243010 [details] new nib Assuming we want this, here's a nib that changes it to "Always Accept" "Don't Connect" "Accept Once" (the last matching the keychain dialogs and giving us more room to work with). I'm ambivalent, as Stop seems fine to me, but let's decide one way or the other and get it off the list. The strings: "StopButton" = "Stop"; -> "Don't Connect"; "Accept Once" = "Accept One Time Only"; -> "Accept Once"; will also need to change; they don't appear to be used at the moment, but they should stay consistent in case they are.
Comment on attachment 243010 [details] new nib The changes are fine and the nib looks good, but while we're touching the nib, can we fix the tab chain? 1) The initial focus (under FKA) is something invisible 2) There are 2-3 other invisible items in the tab chain (seems like 3 in the initial case and 2 once you've tabbed around once?) 3) We should probably put initial focus for FKA on the "Don't Connect" button (a la bug 328048) so that space behaves like it does for FKA in well-behaved apps.
Created attachment 243021 [details] with fixed tabbing As requested
Comment on attachment 243021 [details] with fixed tabbing r=ardissone Requesting rs from pink; this just changes "Stop" to "Don't Connect" and fixes the tab chain to work under full keyboard access.
Whiteboard: [strings changes in comment 3]
Assignee: nobody → stuart.morgan
Comment on attachment 243021 [details] with fixed tabbing rs=pink
Attachment #243021 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [strings changes in comment 3] → [strings changes in comment 3][needs checkin]
Checked in on 1.8branch and trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [strings changes in comment 3][needs checkin] → [strings changes in comment 3]
You need to log in before you can comment on or make changes to this bug.