343990 - Remove unused files

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

Let's remove some old files.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - patches resources/jar.mn to cease packaging the deleted files

In addition to this patch, the following files will be removed entirely from the tree.

R calendar/resources/content/about.html
R calendar/resources/content/about.xul
R calendar/resources/content/calExtOverlay.js
R calendar/resources/content/calExtOverlay.xul
R calendar/resources/content/calendar.xul
R calendar/resources/content/contents.rdf
R calendar/resources/content/menuOverlay.xul
R calendar/resources/content/sunbird_small.png
R calendar/resources/skin/classic/contents.rdf
R calendar/resources/skin/modern/contents.rdf


Also please note that this bug does _NOT_ attempt to remove the old xpfe preferecnes. That is bug 343601

Comment 2

[Matthew (lilmatt) Willis]

lxr searches for the removed files.
Note that calendar.xul's result is misleading since we're _not_ removing Sunbird's calendar.xul


R calendar/resources/content/about.html
http://landfill.mozilla.org/mxr-test/mozilla/search?string=about.html&find=%2Fcalendar%2F&filter=

R calendar/resources/content/about.xul
http://landfill.mozilla.org/mxr-test/mozilla/search?string=about.xul&find=%2Fcalendar%2F&filter=

R calendar/resources/content/calExtOverlay.js
http://landfill.mozilla.org/mxr-test/mozilla/search?string=calExtOverlay.js&find=%2Fcalendar%2F&filter=

R calendar/resources/content/calExtOverlay.xul
http://landfill.mozilla.org/mxr-test/mozilla/search?find=%2Fcalendar%2F&string=calExtOverlay.xul

R calendar/resources/content/calendar.xul
http://landfill.mozilla.org/mxr-test/mozilla/search?string=calendar.xul&find=%2Fcalendar%2F&filter=

R calendar/resources/content/contents.rdf
R calendar/resources/skin/classic/contents.rdf
R calendar/resources/skin/modern/contents.rdf
http://landfill.mozilla.org/mxr-test/mozilla/search?string=contents.rdf&find=%2Fcalendar%2F&filter=

R calendar/resources/content/menuOverlay.xul
http://landfill.mozilla.org/mxr-test/mozilla/search?string=menuOverlay.xul&find=%2Fcalendar%2F&filter=

R calendar/resources/content/sunbird_small.png
http://landfill.mozilla.org/mxr-test/mozilla/search?string=sunbird_small.png&find=%2Fcalendar%2F&filter=

Comment 3

[Matthew (lilmatt) Willis]

Attachment: rev1 - does a little more cleanup after mxr searches (CHECKED IN)

The previous list of removed files remains the same.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 228682 [details] [diff] [review]
rev1 - does a little more cleanup after mxr searches (CHECKED IN)

r=mvl
Let's hope we don't break the part of the world we still care about.

Comment 5

[Matthew (lilmatt) Willis]

rev 1 patch and list of removed files landed on MOZILLA_1_8_BRANCH and trunk

Comment 6

[Matthew (lilmatt) Willis]

Attachment: rev0 - stops packaging modern skin

Also remove the following:

/mozilla/calendar/resources/skin/modern/alertDialog.css
/mozilla/calendar/resources/skin/modern/all_day_event.png
/mozilla/calendar/resources/skin/modern/all_day_event_down.png
/mozilla/calendar/resources/skin/modern/all_day_event_hover.png
/mozilla/calendar/resources/skin/modern/btn1.png
/mozilla/calendar/resources/skin/modern/calendar-16.gif
/mozilla/calendar/resources/skin/modern/calendar-button.css
/mozilla/calendar/resources/skin/modern/calendar.css
/mozilla/calendar/resources/skin/modern/calendar_topbar.gif
/mozilla/calendar/resources/skin/modern/calendartoolbar.png
/mozilla/calendar/resources/skin/modern/calendartoolbar_small.png
/mozilla/calendar/resources/skin/modern/dialogOverlay.css
/mozilla/calendar/resources/skin/modern/dot.png
/mozilla/calendar/resources/skin/modern/dot_selected.png
/mozilla/calendar/resources/skin/modern/eventDialog.css
/mozilla/calendar/resources/skin/modern/overlay.css
/mozilla/calendar/resources/skin/modern/pageupdown.png
/mozilla/calendar/resources/skin/modern/prefs.css
/mozilla/calendar/resources/skin/modern/prevnextarrow.png
/mozilla/calendar/resources/skin/modern/selectAddresses.css
/mozilla/calendar/resources/skin/modern/synch_animated.gif
/mozilla/calendar/resources/skin/modern/taskbar-cal-act.gif
/mozilla/calendar/resources/skin/modern/taskbar-cal.gif
/mozilla/calendar/resources/skin/modern/taskbar-calalarm-act.gif
/mozilla/calendar/resources/skin/modern/taskbar-calalarm.gif
/mozilla/calendar/resources/skin/modern/week-view-corner.png
/mozilla/calendar/resources/skin/modern/datetimepickers/calendar_down.png
/mozilla/calendar/resources/skin/modern/datetimepickers/calendar_hover.png
/mozilla/calendar/resources/skin/modern/datetimepickers/clock_down.png
/mozilla/calendar/resources/skin/modern/datetimepickers/clock_hover.png
/mozilla/calendar/resources/skin/modern/datetimepickers/datepicker.css
/mozilla/calendar/resources/skin/modern/datetimepickers/datetimepickers.css
/mozilla/calendar/resources/skin/modern/datetimepickers/left-arrow-hover.gif
/mozilla/calendar/resources/skin/modern/datetimepickers/left-arrow.gif
/mozilla/calendar/resources/skin/modern/datetimepickers/minimonth.css
/mozilla/calendar/resources/skin/modern/datetimepickers/right-arrow-hover.gif
/mozilla/calendar/resources/skin/modern/datetimepickers/right-arrow.gif
/mozilla/calendar/resources/skin/modern/datetimepickers/timepicker.css
/mozilla/calendar/resources/skin/modern/unifinder/checkbox_checked.png
/mozilla/calendar/resources/skin/modern/unifinder/checkbox_unchecked.png
/mozilla/calendar/resources/skin/modern/unifinder/priority_header.png
/mozilla/calendar/resources/skin/modern/unifinder/priority_high.png
/mozilla/calendar/resources/skin/modern/unifinder/priority_low.png

Since all of these will show up in lxr as "still in use" since we are retaining most of the "classic" skin, I'm not including those links.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 228774 [details] [diff] [review]
rev0 - stops packaging modern skin

you also need to fix /calendar/installer/windows/browser.jst to not try to install modern.
r=mvl with that fixed

Comment 8

[Matthew (lilmatt) Willis]

Found another one to delete:

/mozilla/calendar/resources/content/calendarManagement.js

r?mvl

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

I very much assume you wanted to say calendarManager.js
r=mvl if that's the case.

Comment 10

[Matthew (lilmatt) Willis]

Closing this as we got rid of a bunch o' cruft