344129 - download.js and variables changes need to be ported to mozilla.org

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We've made a bunch of changes to the download.js and probably the variables on mozilla.com that need to be ported back to mozilla.org.  These include at least:
 * changes to offer universal binaries (although if it's not simultaneous it's mainly stuff like the icon)
 * changes to not offer mac builds for South Asian localizations, where they don't work
and perhaps some other things.  It's worth starting to look at getting this stuff ready to offer beta1 from mozilla.org a little before we ship and want to type in the Web page changes.

Comment 1

[Reed Loden [:reed]]

Attachment: First attempt at porting the download.js from m.c to m.o

Here's a quick try at porting download.js over. Not sure what exactly should go in the fxbeta/tbbeta slots for the various locales.

Comment 2

[Reed Loden [:reed]]

Attachment: Second attempt (includes VARIABLES changes)

I used http://lxr.mozilla.org/mozilla1.8/source/browser/locales/shipped-locales for the list of locales to get b1. Please make sure I did "ja" and "ja-JP-mac" correctly.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Have you tested these in a local pull of the webtree?

Comment 4

[Reed Loden [:reed]]

(In reply to comment #3)
> Have you tested these in a local pull of the webtree?

Nope, I don't have a local built copy.

steven: Would you mind testing this?

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It looks like you merged buildValidForPlatform into two places -- the second time into getLanguageIDs.  But you're going to discover more by testing than by reading.

Comment 6

[Steven Garrity [:sgarrity]]

Checked-in version of reed's patch with some minor changes.

Comment 7

[Reed Loden [:reed]]

Comment on attachment 228970 [details] [diff] [review]
Second attempt (includes VARIABLES changes)

I've corrected the error in download.js.