344284 - saved search history not imported from Safari

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[juan becerra [:juanb]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1

Saved form history is not imported from Safari.

To recreate:
1. Open Safari, visit google, and search for "mozilla" (making sure Safari is set to remember form data)
2. Close Safari and open Firefox and go to File > Import and select Safari from the list to import data from Safari
3. Open google.com and start typing a search for "mozilla"

Expected: Firefox should auto-complete the search string. It is supposed to have imported the saved form history from Safari.

Actual: No auto-completion.

Comment 1

[(not reading, please use [e-mail] instead)]

gavin / dietrich, this could be a result of the uninitialized rv that we were discusing over email!

Comment 2

[(not reading, please use [e-mail] instead)]

http://lxr.mozilla.org/seamonkey/source/browser/components/migration/src/nsSafariProfileMigrator.cpp#996, rv is uninitialized.

I have a patch, but I will confirm that it will also fix this bug.

Comment 3

[(not reading, please use [e-mail] instead)]

style sheets is something else (an initialized variable) and I will spin it off to a new bug.

there are a couple reason we don't import saved form data.

1) we need to fix nsSafariProfileMigrator::GetMigrateData() to check if there are saved searches (see how nsSafariProfileMigrator::CopyFormData() works), and if so, do something like:

*aResult |= nsIBrowserProfileMigrator::FORMDATA;

this should cause Form Data to show up in the migration UI (see screen shot), and if checked, will cause us to call CopyFormData()

2)  there are other saved form data in ~/Library/Safari/Form Values, but we don't currently have code to extract that.

I think issue #1 should be easy to fix, and issue #2 I am not sure.  (if you believe http://forums.macosxhints.com/showthread.php?p=329399, that data is encrypted with the "Safari Forms AutoFill" stored in the key chain

Comment 4

[(not reading, please use [e-mail] instead)]

I have a patch that will import the RecentSearchStrings (from the google search box in safari) into the searchbar-history of firefox, but that's just the "easy issue" from my comment #3.

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of the migration dialog (notice "Saved Form History" item)

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 246378 [details] [diff] [review]
patch

Sorry for the delay, this looks fine.

Comment 8

[(not reading, please use [e-mail] instead)]

patch landed.

morphing bug to cover "saved search history" and will spin off a new bug about "saved form history", which is a bigger fish (see comment #3).

Checking in nsSafariProfileMigrator.cpp;
/cvsroot/mozilla/browser/components/migration/src/nsSafariProfileMigrator.cpp,v  <--  nsSafariProfileMigrator.cpp
new revision: 1.35; previous revision: 1.34
done
Checking in nsSafariProfileMigrator.h;
/cvsroot/mozilla/browser/components/migration/src/nsSafariProfileMigrator.h,v  <--  nsSafariProfileMigrator.h
new revision: 1.18; previous revision: 1.17
done

Comment 9

[Marcia Knous [:marcia]]

Any chance we can get this patch on the trunk? During M8 testing I am noticing we are little lean on migration.

Comment 10

[Marcia Knous [:marcia]]

Bug 363488 covers the issue of the saved form history.