344370 - let declaration in let statement shows assertion

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[nanto_vi (TOYAMA Nao)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: 

If let declarations appear just in a let statement, an assertion is shown.

Reproducible: Always

Steps to Reproduce:
js> let (a = 2) { let b = 3; [a, b]; }

Actual Results:  
Assertion failure: fp->spbase + OBJ_BLOCK_DEPTH(cx, obj) == sp, at jsinterp.c:5947

Expected Results:  
2,3

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

I have a patch and need to look it over once more. I'll attach it here for safekeping.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 229024 [details] [diff] [review]
Proposed fix

MAYBE_, not MAY_BE_

Macro indentation madness

Set pn1->pn_pos = tc->blockNode->pn_pos when making a TOK_LEXICALSCOPE node.

/be

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Updated patch

I added a rider to get the index right when we're looking at the second let declaration (starting at the current count instead of always at 0).

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 229694 [details] [diff] [review]
Updated patch

Looks good, thanks.

/be

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 7

[Bob Clary [:bc] (inactive)]

Checking in regress-344370.js;
/cvsroot/mozilla/js/tests/js1_7/block/regress-344370.js,v  <--  regress-344370.js
initial revision: 1.1

Comment 8

[Bob Clary [:bc] (inactive)]

Do we want this on 1.8 as well?

verified fixed 20060723 trunk windows/mac*/linux

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 229694 [details] [diff] [review]
Updated patch

This patch has been on the trunk for a week. It has not caused any known regressions, and it fixes several bugs in let expressions. Despite the large amounts of code that it touches, it shouldn't actually affect anything other than let statements.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 229694 [details] [diff] [review]
Updated patch

a=drivers. Please land this on the MOZILLA_1_8_BRANCH.

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

Fixed on the 1.8 branch.

Comment 12

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.1, 1.9 windows/mac(ppc|tel)/linux