Closed Bug 348375 Opened 18 years ago Closed 18 years ago

Buggy break in EmitNonLocalJumpFixup

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta2

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

(Keywords: fixed1.8.1, regression)

Attachments

(1 file)

Fix
775 bytes, patch
brendan
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
When I copy/pasted the SIF_SCOPE case in EmitNonLocalJumpFixup, I copy/pasted the 'break' from the case statement, so we'll fail to pop anything above the first scope statement on our way up the stack.
Priority: -- → P1
Attached patch Fix — — Splinter Review 
Ugh, 'break' is so overloaded.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #233273 - Flags: review?(brendan)
Safe fix, and must-fix for 1.8.1.

/be
Flags: blocking1.8.1?
Attachment #233273 - Flags: review?(brendan) → review+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #233273 - Flags: approval1.8.1?
Flags: blocking1.8.1? → blocking1.8.1+
Comment on attachment 233273 [details] [diff] [review]
Fix

a=mconnor on behalf of drivers for 1.8 branch
Attachment #233273 - Flags: approval1.8.1? → approval1.8.1+
Fixed on the 1.8 branch.
Keywords: fixed1.8.1
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: