Buggy break in EmitNonLocalJumpFixup

RESOLVED FIXED in mozilla1.8.1beta2

Status

()

Core
JavaScript Engine
P1
major
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

({fixed1.8.1, regression})

Trunk
mozilla1.8.1beta2
fixed1.8.1, regression
Points:
---
Bug Flags:
blocking1.8.1 +
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
When I copy/pasted the SIF_SCOPE case in EmitNonLocalJumpFixup, I copy/pasted the 'break' from the case statement, so we'll fail to pop anything above the first scope statement on our way up the stack.
(Assignee)

Updated

11 years ago
Priority: -- → P1
(Assignee)

Comment 1

11 years ago
Created attachment 233273 [details] [diff] [review]
Fix

Ugh, 'break' is so overloaded.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #233273 - Flags: review?(brendan)
Safe fix, and must-fix for 1.8.1.

/be
Flags: blocking1.8.1?

Updated

11 years ago
Attachment #233273 - Flags: review?(brendan) → review+
(Assignee)

Comment 3

11 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Attachment #233273 - Flags: approval1.8.1?
Flags: blocking1.8.1? → blocking1.8.1+
Comment on attachment 233273 [details] [diff] [review]
Fix

a=mconnor on behalf of drivers for 1.8 branch
Attachment #233273 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Comment 5

11 years ago
Fixed on the 1.8 branch.
Keywords: fixed1.8.1

Updated

11 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.