344381 - browser.search.openintab should use blank tab

Status: RESOLVED DUPLICATE of bug 1455326

(Firefox :: Search, defect, P3)

Description

[nathaniel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1

When browser.search.openintab is enabled, and a blank tab is open, instead of opening a new tab, it should use that blank tab.

This helps the user transition from not using this option as they were probably used to making a new tab before doing a search.

Reproducible: Always

Steps to Reproduce:
1. Enabled browser.search.openintab
2. Open new, blank tab
3. Perform search

Actual Results:  
A new tab is opened (actually two, but that's another bug).

Expected Results:  
The search should utilize the unused blank tab.

Comment 1

[Stebs]

This is a duplicate of Bug 320989 Reuse last tab if blank
Could you resolve it as duplicate please?

Comment 2

[nathaniel]

*** This bug has been marked as a duplicate of 320989 ***

Comment 3

[:Gavin Sharp [email: [e-mail]]]

No, this isn't a duplicate.

Comment 4

[Armin Fuerst]

This still would be nice in 3.x and newer...

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Still happens with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090504 Minefield/3.6a1pre ID:20090504031236

It depends on how you start the search. We have a discrepancy here between hitting Enter or clicking the magnifying glass. The latter one always opens the search results in the current tab while the former one creates a new tab. Both should have the same behavior.

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> It depends on how you start the search. We have a discrepancy here between
> hitting Enter or clicking the magnifying glass. The latter one always opens the
> search results in the current tab while the former one creates a new tab. Both
> should have the same behavior.

The mignifying glass has the common modifiers, i.e. shift, control and middle-click.

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch

Comment 11

[Mark Banner (:standard8)]

Dao, I think this has been fixed by bug 1455326. Do you agree?