344559 - Add Commit Button below the top fields on show_bug.cgi

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement, P1)

Description

[Rob Greer]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; InfoPath.1; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Build Identifier: All Bugzilla Versions - Browser Independent

Since many bug changes only relate to the initial Bugzilla form elements, to remove the need for scrolling, I propose adding a Commit button to the top fold of the bug report screen in addition to the Commit button found below the fold.

Reproducible: Always

Steps to Reproduce:
1. NA
Actual Results:  
N/A

Comment 1

[Wayne Mery (:wsmwk)]

would be nice to see "add ... to cc list" next to it which is where it belongs (IMO, plus not waste vertical space)

Comment 2

[Max Kanat-Alexander]

Sounds reasonable to me.

Comment 4

[Guy Pyrzak]

Attachment: Commit Top Patch V1

attempt 1

Comment 5

[Guy Pyrzak]

Comment on attachment 336282 [details] [diff] [review]
Commit Top Patch V1

oops forgot the user.id if

Comment 6

[Guy Pyrzak]

Attachment: Commit Top Patch V2

Comment 7

[Gervase Markham [:gerv]]

An alternative option to multiplying commit buttons would be to add a shortcut key. We used to have more of those, but we removed them because they clashed with menus, as Firefox used the same accelerator (Alt). I think this has now been changed, so we could have Alt-Shift-C as Commit using only HTML.

Gerv

Comment 8

[Dave Miller [:justdave]]

Adding this to bmo-regressions for tracking, since this has been a common complaint among bmo users.  As a side-note, the current patch does not apply cleanly to the bmo/3.2 branch.

Comment 9

[Dave Miller [:justdave]]

I fixed this patch to apply to bmo (see revision 6138 on the bmo/3.2 bzr branch), but I'm not sure it's all there yet.  The most common changes made seem to be around status/resolution and CC list, and it still requires scrolling to get to the buttom from those actions.  I'm thinking it should probably be up towards the actual top of the form somewhere.  I did commit it to bmo as-is though, because it's still loads better than having to scroll down past the comment. :)

Comment 10

[Gábor Stefanik]

We really need an "In progress" status for bugs like this...

Comment 11

[Frédéric Buclin]

(In reply to comment #10)
> We really need an "In progress" status for bugs like this...

Why? I don't see why this would be useful.

Comment 12

[Max Kanat-Alexander]

Comment on attachment 336291 [details] [diff] [review]
Commit Top Patch V2

I'd rather just have it at the top of the page, kind of like you have it in PRACA.

Comment 13

[Guy Pyrzak]

Attachment: V3 of patch

Comment 14

[Max Kanat-Alexander]

Comment on attachment 358870 [details] [diff] [review]
V3 of patch

Looks great.

We should also change the text to "Save Changes" like you guys did in PRACA. Maybe in another bug?

Comment 15

[Reed Loden [:reed]]

bmo took this on 3.2, so it seems reasonable just to get this into 3.2 proper.

Comment 16

[Frédéric Buclin]

Comment on attachment 358870 [details] [diff] [review]
V3 of patch

>+          [% PROCESS commit_button id=""%]

Missing whitespace after "".


>+      [% PROCESS commit_button id="_top"%]

Same here.


Please add them on checkin.

Comment 17

[Max Kanat-Alexander]

No, this won't go into 3.2, it's an enhancement. It's also not the same thing that bmo has. It would, in fact, break one of bmo's customizations.

Comment 18

[Guy Pyrzak]

Checking in bugzilla/skins/standard/show_bug.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/show_bug.css,v  <--  show_bug.css
new revision: 1.11; previous revision: 1.10
done
Checking in bugzilla/template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.150; previous revision: 1.149
done