344572 - [newprefs] Unit of measure for history preference not spoken by WindowEyes

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Mark Pilgrim (inactive)]

Steps to reproduce:

1. Run WindowEyes v5.5K
2. Run a trunk build of Firefox that has the newly reorganized prefs window
3. Tools / Options / Privacy
4. Tab to "Remember visited pages for the last [   ] days" and/or the edit box itself where you can enter the number of days

Results:

On the checkbox, WindowEyes speaks the literal text of the checkbox, "Remember visited pages for the last.  Checkbox.  Checked."  On the edit box, WindowEyes speaks the "9" but does not speak "days" (the unit of measure).

Expected behavior:

In Firefox 1.5, you could tab to the number of days editbox and WindowEyes would speak the entire label on both sides, plus the current value, i.e. "Remember visited pages for the last 9 days."

Comment 1

[Mark Pilgrim (inactive)]

Attachment: restore labelledby solution from firefox 1.5

Firefox 1.5 used a "DHTML Accessibility" labelledby trick to make the textbox by "labeled by" the containing box, which includes the unit of measure label.  So compliant ATs (such as WindowEyes) will speak the unit of measure along with the current value of the text box.

Comment 2

[Mike Schroepfer]

Mark you should land this on trunk immediately so we let it bake for a few days before landing on 1.8 branch.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: what I landed on the trunk

mozilla/browser/components/preferences/privacy.xul 	1.16

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 231095 [details] [diff] [review]
restore labelledby solution from firefox 1.5

This would be good to have for branch.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 231095 [details] [diff] [review]
restore labelledby solution from firefox 1.5

a=drivers, please land on the branch

Comment 6

[Jeff Walden [:Waldo]]

Fixed on branch.

Comment 7

[Mark Pilgrim (inactive)]

*** Bug 347222 has been marked as a duplicate of this bug. ***