344588 - [newprefs] Certificates preference associated label not spoken by WindowEyes

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Mark Pilgrim (inactive)]

Requires WindowEyes 5.5K and a Firefox build with the newly reorganized preferences window (bug 340677).

Step to reproduce:

1. Tools / Options / Advanced / Encryption
2. Tab to radio button in Certificates group box

Results:

WindowEyes speaks "Select one automatically"

Expected results:

WindowEyes should also speak the associated label, i.e. "When a web site requires a certificate: Select one automatically."

Comment 1

[Mark Pilgrim (inactive)]

Problem also exists in Firefox 1.5.  Removing "regression" keyword.

Comment 2

[Mark Pilgrim (inactive)]

*** Bug 347235 has been marked as a duplicate of this bug. ***

Comment 3

[Marco Zehe (:MarcoZ)]

Attachment: patch that links the description and the radio group together so the radio group appears properly labelled.

This patch addresses the issue that currently no label is spoken when landing on the radio buttons. This does, however, not pick up the fact that we're in the Certificates groupbox. Only when tabbing onwards from the radio button group to the buttons, do screen readers pick this up. There does not appear to be a way of also including the caption for the groupbox in the aaa:labelledby attribute. I tried, and it fails.

Comment 4

[Marco Zehe (:MarcoZ)]

Ginn, do you have an idea why the caption is not included in the accessible name for the radio group, if I also give the caption an ID, and put that ID alongside the ID for the description in the aaa:labelledby attribute?

Comment 5

[Marco Zehe (:MarcoZ)]

Attachment: Patch with the desired two labels for the radio group. Currently does not produce any different output than original patch.

This patch shows the way I really would like it to come out in the end. However for this to work, changes in code may be required for the ID of the XUL:caption to be linked in properly.

Comment 6

[Ginn Chen]

(In reply to comment #4)
> Ginn, do you have an idea why the caption is not included in the accessible
> name for the radio group, if I also give the caption an ID, and put that ID
> alongside the ID for the description in the aaa:labelledby attribute?
> 

I'm not sure.

Comment 7

[Ginn Chen]

Macro,

that's a bug. sigh.
Technically caption is not a label.
And we don't create accessible object for caption, we create an accessible object for the label inside it. 

Check accessible/src/base/nsAccessible.cpp
nsAccessible::AppendFlatStringFromContentNode
Line 1587-1600

BTW: there's a typo in your patch
control="certselection" should be control="certSelection"

Comment 8

[Ginn Chen]

Comment on attachment 284629 [details] [diff] [review]
patch that links the description and the radio group together so the radio group appears properly labelled.

certselection should be
certSelection

It's case-sensitive.

Comment 9

[Marco Zehe (:MarcoZ)]

(In reply to comment #7)
> Technically caption is not a label.
> And we don't create accessible object for caption, we create an accessible
> object for the label inside it. 

OK, so the "only" part is: How do I reference that label from another control to have it describe/label something? :-)

> BTW: there's a typo in your patch
> control="certselection" should be control="certSelection"

Thanks for the pointer! That's a part I actually didn't touch, so the typo has been there all along. I've corrected it and will put up a new patch soon.
So the remaining question is: Do I have a means to reference that label, or is this currently impossible?

Comment 10

[Ginn Chen]

If you want to have the <caption> as part of the accessible name for radio group.
You can file a bug and assign it to Evan Yan or me.
Thanks!

Comment 11

[Marco Zehe (:MarcoZ)]

Attachment: Updated patch

Addresses typo in control attribute.
I will add a bug for the caption that cannot be referenced by aaa:labelledby, as also shown in this patch.

Comment 12

[Asaf Romano (gone)]

Comment on attachment 286537 [details] [diff] [review]
Updated patch

r=mano

Comment 13

[Reed Loden [:reed]]

Checking in browser/components/preferences/advanced.xul;
/cvsroot/mozilla/browser/components/preferences/advanced.xul,v  <--  advanced.xul
new revision: 1.42; previous revision: 1.41
done