344625 - When Error Console is shut, the object leaks

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Hiro]

Reproducible: Always

Leaks in window 0x43017a8:
[+] [leaked object] (443fb40) = [object Object]
 [+] console (443fed8) = [object XULElement]
  [ ] limit = 250
  [ ] _showChromeErrors = true
  [ ] mSelectedItem = null
  [ ] mCount = 250
  [-] mConsoleListener (443fb40) = [object Object]
  [ ] mConsoleRowBox (443fac0) = [object XULElement]
  [+] mStrBundle (443fdf8) = [object XULElement]
   [-] _bundle (638c018) = [xpconnect wrapped nsIStringBundle]
  [ ] mCService (443fa78) = [xpconnect wrapped nsIConsoleService]
  [ ] mMode = Errors
 [+] observe (443fb38, chrome://global/content/consoleBindings.xml, 75-75) = function (aObject) {
    this.console.appendItem(aObject);
}
  [ ] prototype (23db958) = [object Object]

Windows XP SP1
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060713 Minefield/3.0a1

Comment 1

[Adam Guthrie]

Could you give more accurate steps to reproduce? I couldn't reproduce in a current trunk build on Linux.

Comment 2

[Hiro]

(In reply to comment #1)
> Could you give more accurate steps to reproduce? I couldn't reproduce in a
> current trunk build on Linux.
> 

Error Console is opened and it shuts. 
Even if only "Leak Monitor extention" is installed with a new profile, it reproduces. 

Step:
1. Open Error Console
2. Close Error Console

Comment 3

[Hiro]

Mac build reproduced. 

Mac OS X 10.3.9
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060714 Minefield/3.0a1

Comment 4

[u88484]

Can also reproduce on windows with latest trunk

Comment 5

[Régis Caspar]

Attachment: leak alert with Console²

(In reply to comment #4)
> Can also reproduce on windows with latest trunk
FWIW, a similar (on closure) leak occurs with Console² (see attachment)
I nullified the this.mConsoleListener in chrome://global/content/consoleBindings.xml (tested on a clean profile with regular Error Console) but I still get an alert about a null object (this.mConsoleListener) leaked. 
This let me think that perhaps nsIConsoleService.unregisterListener() somehow fails...

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060717 Minefield/3.0a1 ID:2006071709 [cairo]

Comment 6

[Brian Polidoro]

Here the regression range I found:
2006071304 doesn't leak
2006071314 leaks

I'm lucky I still had the 1314 hourly build.  

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-07-13+03%3A00%3A00&maxdate=2006-07-13+14%3A00%3A00&cvsroot=%2Fcvsroot

Comment 7

[Brian Polidoro]

I no longer see this leak.  Instead the clear button no longer works on the error console.  

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060720 Minefield/3.0a1 ID:2006072004 [cairo]

Comment 8

[Brian Polidoro]

It seems like this was fixed by bug 344623.  That has a regression range within the regression range of this bug. And the fix for that is new in this nightly.  

The clear button problem is either a side effect or a separate coincidence. I filed a new bug for that (Bug 345327).