345327 - Clear button does not work

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[Brian Polidoro]

The clear button does not clear the error console.  Although after pressing the clear button then closing and reopening the console, then the console is cleared.

Recently There was a leak in the console (bug 344625) which appears to have been fixed by bug 344623.  I'm not sure if that's related.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Seems to me like the logStringMessage(null) call should be after the .reset() call instead of before.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/console/content/consoleBindings.xml&rev=1.12&mark=208#205

Comment 2

[Simon Bünzli]

Attachment: actually handle the "null"/clear message

Seems that I forgot to remove this check when porting the patch to the clean CVS tree. Sorry for this breakage.

The issue is that the "null" messages which have so far been used to mark the point until which messages should be displayed in the console and which are now used to indicate that an open console should be cleared are prematurely discarded.

Comment 3

[Ria Klaassen (not reading all bugmail)]

*** Bug 345374 has been marked as a duplicate of this bug. ***

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/console/content/consoleBindings.xml 	1.13

Comment 5

[Adam Guthrie]

*** Bug 346210 has been marked as a duplicate of this bug. ***