Add UI to delete summary file from folder properties dialog

RESOLVED FIXED

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

({fixed1.8.1})

Trunk
x86
Windows XP
fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

12 years ago
There are enough situations where we tell the user to delete the .msf file that it's worth having UI for this in the folder properties dialog. Folder properties is more or less a power user feature anyway...
(Assignee)

Comment 1

12 years ago
Created attachment 229396 [details] [diff] [review]
proposed fix

This adds a "Rebuild Summary File" button to the folder properties dialog and implements it. In implementing this, I also fixed the problem where some users inbox.msf files were getting regenerated every time they started up and the message counts were doubling.

I made setting a summary file as valid also commit the db, since you pretty much always want to do that, and if you forget, it can cause problems.

I would like to implement a non-destructive regeneration of summary files at some point, one which copies info from the old .msf file, instead of just deleting the .msf file and rebuilding/redownloading the headers. This could be hooked up to this UI, so users would do this instead of deleting the .msf files from their profile dir.
Attachment #229396 - Flags: superreview?(mscott)

Comment 2

12 years ago
Comment on attachment 229396 [details] [diff] [review]
proposed fix

I think we should call this "Rebuild" in the UI instead of Rebuild Summary File. I think that sounds more user friendly.
Attachment #229396 - Flags: superreview?(mscott) → superreview+
(Assignee)

Comment 3

12 years ago
fixed on trunk - will land on 2.0 branch after alpha.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

12 years ago
Comment on attachment 229396 [details] [diff] [review]
proposed fix

setting thunderbird2 flag so I won't forget this
Attachment #229396 - Flags: approval-thunderbird2?
(Assignee)

Updated

12 years ago
Keywords: fixed1.8.1

Comment 5

12 years ago
Cool feature -- but contrary to comment 2, I find the "Rebuild" to be overly terse.  "Rebuild Index" would have been nicer, I think.
(Assignee)

Comment 6

11 years ago
I like Rebuild Index better as well. Scott?

Comment 7

11 years ago
that works for me.
(Assignee)

Comment 8

11 years ago
Created attachment 232644 [details] [diff] [review]
adopt Mike's suggestion

I'll check this in.  The tooltip will still say Rebuild Summary File, but I think that's ok - it's a little bit of extra info.
(Assignee)

Comment 9

11 years ago
Comment on attachment 232644 [details] [diff] [review]
adopt Mike's suggestion

patch checked in.
(Assignee)

Comment 10

11 years ago
Comment on attachment 229396 [details] [diff] [review]
proposed fix

clearing, already landed.
Attachment #229396 - Flags: approval-thunderbird2?
You need to log in before you can comment on or make changes to this bug.