344985 - Change font size setting of Japanese NSIS installer (written in preprocess-locale.pl).

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[dynamis (Tomoya ASAI)]

Bug 343449 was fixed to make our installer can be viewd correctly on Win9x.
But that patch (attachment 227968 [details] [diff] [review]) not only fixed the font face, but also changed the font size. The size specifed in the pache (9) was same size as in standard NSIS installer:
https://bugzilla.mozilla.org/show_bug.cgi?id=343449#c2

But unfortunatlly, that font size was too large. So, we should change (reset) the font size of Japanese NSIS installer. Probably other locales also needs to fix the font size, but I'm not sure and I only request for Japanese installer.

Comment 1

[dynamis (Tomoya ASAI)]

Attachment: 1st page of ja installer with default font size

Comment 2

[dynamis (Tomoya ASAI)]

Attachment: 2nd page of ja installer with default font size

This and previsous screenshots are of ja installer with default font size.

Comment 3

[dynamis (Tomoya ASAI)]

Attachment: 1st page of ja installer with font size 9

Comment 4

[dynamis (Tomoya ASAI)]

Attachment: 2nd page of ja installer with font size 9

This and previsous screenshots are of ja installer after the bug 343449, which set font size for 9.

Comment 5

[Robert Strong (they/them - no direct email)]

Same as bug 344476 and will be fixed in that bug

Comment 6

[dynamis (Tomoya ASAI)]

(In reply to comment #5)
> Same as bug 344476 and will be fixed in that bug

Isn't that bug for Chinese (Simplified) only?
# we can set font size *par locale*

If that bug will change all locales, this bug is the dup of it and I'll write more details and attache a patch to bug 344476.
Or, if that bug will not only change the font but also change the code of NSIS installer and make installer look well with any font size, that's great and this bug is the dup.

Comment 7

[dynamis (Tomoya ASAI)]

IMHO this bug should be used to change font size setting only for ja, and bug 344476 should be used to fix how installer treat the font size setting, which effects to all locales with font size setting.
# So, this bug depends on 34476 but not dup of it.

As you can see, after setting the font size as 9 (I'll write this information in bug 34476 too):
 1. Easy to read for japanese (but a little too large).
 2. Unit of the font size is not clear.
    The font actually used in the installer seems to be 12px, not 9px.
 3. Window size will change according to the windows system settting.
    On the other hand, window size was fixed with default font size.
 4. Only the main part of the installer will be enlarged.
    See the title "License Agreement" in page 2. It is still small and design
    (balance of the font sizes) are not good with font size 9.
 5. Images will be also enlarged according to the font size but it looks poor.
    See firefox icon in the top-right of page 2, which is blurred.

Form 2,3,4, I doubt if the installer font size is not treated correctly.
Idially, if we can do all of the following, that's great:
  * Make the unit of the font size clear.
  * Chage font size of all the text according to the setting.
  * Fix the size of window, not depend on the system setting.
  * Include larger and clear images according to the font size.
# after the fix, we can set font size par locale

But it may be a little difficult to fix all the above problems now (after beta 1) and workaround for this is:
Just remove font setting for the installer and use default font size.

I'm not sure how other locales owners think, but concerning to our ja installer, I want to set ja font larger than en-US one to make easy to read only in case all the relating bug (side-effect) are solved.

Comment 8

[Robert Strong (they/them - no direct email)]

If you want to take and fix this bug then please do... I am planning on fixing this along with bug 344476 at the same time as soon as I have time to do so which should be within the next week.

Comment 9

[dynamis (Tomoya ASAI)]

(In reply to comment #8)
> If you want to take and fix this bug then please do... I am planning on fixing
> this along with bug 344476 at the same time as soon as I have time to do so
> which should be within the next week.

Thanks, that's good news. ;)
If the bug 344476 will be fixed within the next week, we'll wait that.
And after that, I'll change font size if still needed.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

How is this not just a straight dupe of 344476?

Comment 11

[dynamis (Tomoya ASAI)]

(In reply to comment #10)
> How is this not just a straight dupe of 344476?

In short:
This bug is about font size setting in locale.nsi, not about installer code.
http://lxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/installer/windows/nsis/locales.nsi#48
# Changed summary of this bug to make it clear.

Details:
Specifing font size in locale.nsi elicits the problem of installer code but font size setting itself is just config of each locale.
Installer should looks fine independign on it's font size setting and bug 344476 will fix it.
This bug is just for changing font size of Japanese installer.

As I wrote in comment #7
> 2. Unit of the font size is not clear.
>    The font actually used in the installer seems to be 12px, not 9px.
Current font size is larger than I expected with the value 9.
I doubt current installer isn't treating font size correctly and Japanese installer font size will be smaller when bug 344476 is fixed.

If Japanese installer looks fine when bug 344476 is solved, I'll just close this bug. If Japanese installer font looks still too large when bug 344476 is solved, I'll continue to change the font size smaller for ja locale.
# This bug cannot proceed untill bug 344476 is fixed (depends it).

Comment 12

[Robert Strong (they/them - no direct email)]

This is actually caused by the changing the font from MS Shell Dialog to MS UI Gothic or equivalent for the entire ui since the MS UI Gothic font is not the same dimensions and changing the font size does not actually fix this bug. The fix will hopefully be setting the font at runtime as was done in the xpinstall based installer which would be the fix for bug 344476.

Comment 13

[dynamis (Tomoya ASAI)]

(In reply to comment #12)
> This is actually caused by the changing the font from MS Shell Dialog to MS UI
> Gothic or equivalent for the entire ui since the MS UI Gothic font is not the
> same dimensions and changing the font size does not actually fix this bug. The
> fix will hopefully be setting the font at runtime as was done in the xpinstall
> based installer which would be the fix for bug 344476.

Yes, I know that changing the font size does not actually fix this bug.
I believe setting the font at runtime as you say will fix and We don't need to change font size written in locales.nsi actually.
This bug is still open merely since bug 344476 is not fixed yet and I'm not sure if 9 is the best font size for us or not.

Comment 14

[dynamis (Tomoya ASAI)]

Bug 344476 was solved and font size of Japanese installer is now treated correctlly (current font size is set as 9).
# Thanks, Robert!

After the fix of bug 344476, I tested japanese installer with larger font size to find best font size for Japanese installer.
# Sorry, I was busy and cannot read bugmail when robert ask me to check screenshots of fixed installer with font size 9

The result is:

font size 9 is not bad, but a little poor. Line height (space between lines) isn't enough and window width is too wide against it's height.
font size 10 is the best result. Same window width as one of font size 9 but height will be taller. Line height will be enough and easy to read.
font size 11 will be more easy to read but a little too large, especially in low resolution display.

I think we should change font size of Japanese installer from 9 to 10.
I'll attach screenshots with font size 9 and 10.

Comment 15

[dynamis (Tomoya ASAI)]

Attachment: 1st page of fixed installer (font size: 9)

Comment 16

[dynamis (Tomoya ASAI)]

Attachment: 2nd page of fixed installer (font size: 9)

Comment 17

[dynamis (Tomoya ASAI)]

Attachment: 3rd page of fixed installer (font size: 9)

These 3 screenshots are taken with latest L10n nightly (20060911)

Comment 18

[dynamis (Tomoya ASAI)]

Attachment: 1st page of fixed installer (font size: 10)

Comment 19

[dynamis (Tomoya ASAI)]

Attachment: 2nd page of fixed installer (font size: 10)

Comment 20

[dynamis (Tomoya ASAI)]

Attachment: 3rd page of fixed installer (font size: 10)

These 3 screenshots are teken with hacked (with reshacker) installer based on latest L10n nightly (20060911).

Installer dialog width is same but height is taller (same as en-US installer) and easy to read. I think this font size is the best for ja.

Comment 21

[Robert Strong (they/them - no direct email)]

I think it is a bit too late to fix this for 2.0 and for 3.0 this problem is not present since we no longer support win9x on the trunk which is the reason we have this visual glitch.

Comment 22

[dynamis (Tomoya ASAI)]

This is not required for RC1 and IMHO changing font size is easy without risk. Just changing font size and prepare larger images.

Current font size 9 is not acceptable but 10 is clearly better. Installer is the first things people see. With Firefox 3.0, this will be solved but Firefox 2.0.x.x will continue more than a year (used by millions of new users).

It's already before RC1 code freeze but I reported this bug before beta 1 and waited fix of bug 344476 and checked other font size as soon as I can after the fix of the bug.

Is it impossible to rethink about accepting this change?

Comment 23

[Robert Strong (they/them - no direct email)]

Sure, if you can create the patch and drive it through to it landing. At the moment I don't have the time to do this.

Comment 24

[dynamis (Tomoya ASAI)]

(In reply to comment #23)
> Sure, if you can create the patch and drive it through to it landing. At the
> moment I don't have the time to do this.

I and masayuki is working for this now. We made image files for Fx/Tb/Sb and testing to build installer correctlly so far (Fx is already built and it worked well).

I'll attach images for Fx/Tb/Sb installer.
# This change effects all of Fx/Tb/Sb and I change product of this bug to toolkit

Comment 25

[dynamis (Tomoya ASAI)]

Attachment: official firefox header for font size10

Comment 26

[dynamis (Tomoya ASAI)]

Attachment: official firefox watermark for font size10

Comment 27

[dynamis (Tomoya ASAI)]

Attachment: unofficial firefox header for font size10

Comment 28

[dynamis (Tomoya ASAI)]

Attachment: unofficial firefox watermark for font size10

Comment 29

[dynamis (Tomoya ASAI)]

Attachment: official thunderbird header for font size10

Comment 30

[dynamis (Tomoya ASAI)]

Attachment: official thunderbird watermark for font size10

Comment 31

[dynamis (Tomoya ASAI)]

Attachment: unofficial thunderbird header for font size10

Comment 32

[dynamis (Tomoya ASAI)]

Attachment: unofficial thunderbird watermark for font size10

Comment 33

[dynamis (Tomoya ASAI)]

Attachment: official sunbird header for font size10

Comment 34

[dynamis (Tomoya ASAI)]

Attachment: unofficial sunbird header for font size10

Comment 35

[dynamis (Tomoya ASAI)]

Attachment: unofficial sunbird watermark for font size10

Comment 36

[dynamis (Tomoya ASAI)]

Regarding official sunbird watermark image, I don't have vector graphic of sunbird logo and cannot make it. :( I send mail to Mark Carson (designer of Sunbird logo) to give us but have not got responce yet.

The size of watermark image for ja font size 10 will be 191x314, which is wider than wizWatermark.bmp and heighter than wizWatermark2.bmp and wizWatermark3.bmp

You made wizWatermark2.bmp (wider than wizWatermark.bmp) in bug 351645 and I think you have vector graphic (or just very large) Sunbird logo. Chould you give me or made the logo instead of us please, Robert?

Comment 37

[Robert Strong (they/them - no direct email)]

Take a look at bug 344476 - the images must be unoptimized bitmaps and not png's

Comment 38

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

testing now...

Comment 39

[dynamis (Tomoya ASAI)]

(In reply to comment #37)
> Take a look at bug 344476 - the images must be unoptimized bitmaps and not
> png's

Of cource I made bitmaps and masayuki is building with bitmap. But I heard that bugzilla have size limit to attach binary and attached  png version to make review easy.
# you also attached png in bug 344476, 351644, 351645 isn't it?

 c.f. you can see original bitmap version here:
http://ftp.firehacks.org/toolkit/installer/firefox/official/
http://ftp.firehacks.org/toolkit/installer/firefox/unofficial/
http://ftp.firehacks.org/toolkit/installer/thunderbird/official/
http://ftp.firehacks.org/toolkit/installer/thunderbird/unofficial/
http://ftp.firehacks.org/toolkit/installer/sunbird/official/
http://ftp.firehacks.org/toolkit/installer/sunbird/unofficial/

Comment 40

[Robert Strong (they/them - no direct email)]

The bitmaps will fit as shown in bug 344476 and the review needs to verify that they haven't been optimized, etc.

No, those are bitmaps which bugzilla detects as png.

Comment 41

[dynamis (Tomoya ASAI)]

(In reply to comment #40)
> No, those are bitmaps which bugzilla detects as png.

Ahh sorry, I didn't noticed that.
I'll attach bitmap versions.

Comment 42

[dynamis (Tomoya ASAI)]

Attachment: official firefox header for font size10

replace png attachements with bitmap

Comment 43

[dynamis (Tomoya ASAI)]

Attachment: official firefox watermark for font size10

Comment 44

[dynamis (Tomoya ASAI)]

Attachment: unofficial firefox header for font size10

Comment 45

[dynamis (Tomoya ASAI)]

Attachment: unofficial firefox watermark for font size10

Comment 46

[dynamis (Tomoya ASAI)]

Attachment: official thunderbird header for font size10

Comment 47

[dynamis (Tomoya ASAI)]

Attachment: official thunderbird watermark for font size10

Comment 48

[dynamis (Tomoya ASAI)]

Attachment: unofficial thunderbird watermark for font size10

Comment 49

[dynamis (Tomoya ASAI)]

Attachment: unofficial thunderbird header for font size10

Comment 50

[dynamis (Tomoya ASAI)]

Attachment: official sunbird header for font size10

Comment 51

[dynamis (Tomoya ASAI)]

Attachment: unofficial sunbird header for font size10

Comment 52

[dynamis (Tomoya ASAI)]

Attachment: unofficial sunbird watermark for font size10

Comment 53

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

now, I completed to test.

I changed the font size of UI and added 4th image for Japanese Installer.

Comment 54

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: screenshot: current installer(left) vs. patched installer(right)

Comment 55

[Matthew (lilmatt) Willis]

Comment on attachment 238503 [details]
unofficial sunbird header for font size10

r=lilmatt

Comment 56

[Matthew (lilmatt) Willis]

Comment on attachment 238502 [details]
official sunbird header for font size10

r1=lilmatt

Comment 57

[Matthew (lilmatt) Willis]

Comment on attachment 238504 [details]
unofficial sunbird watermark for font size10

r1=lilmatt

Comment 59

[Mike Beltzner [:beltzner, not reading bugmail]]

All these images look fine; you don't really need my review on them if all you're doing is changing the size a little :)

Like Robert, I don't know if drivers will accept these landings. When you get all your reviews, please nominate them for 1.8.1 approval and we'll see.

Comment 60

[Robert Strong (they/them - no direct email)]

By chance did you check or ask the ko localizers if they would prefer a font size of 10? This would then just replace the one image. If not, could you? Thanks

Comment 61

[Robert Strong (they/them - no direct email)]

(In reply to comment #60)
Nevermind about this... ko looks fine without these changes and the 10 pt font is significantly different which skews the images

Comment 62

[Robert Strong (they/them - no direct email)]

Comment on attachment 238480 [details] [diff] [review]
Patch rv1.0

Looks good and thanks

Comment 63

[Robert Strong (they/them - no direct email)]

Comment on attachment 238498 [details]
official thunderbird header for font size10

mscott is away for the next few days so I'll approve... btw: bsmedberg is away as well.

Comment 64

[Robert Strong (they/them - no direct email)]

Just to be careful... this patch should not land on trunk since this workaround is only required for Win9x and the trunk doesn't support Win9x

Comment 65

[dynamis (Tomoya ASAI)]

Attachment: official sunbird watermark for font size10

(In reply to comment #36)
> Regarding official sunbird watermark image, I don't have vector graphic of
> sunbird logo and cannot make it. :( I send mail to Mark Carson (designer of
> Sunbird logo) to give us but have not got responce yet.

I recieved enough large image from Mark and I made official sunbird watermark image too.

Comment 66

[Matthew (lilmatt) Willis]

Comment on attachment 238704 [details]
official sunbird watermark for font size10

r=lilmatt

Comment 67

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you for reviews.

Robert:
Don't I need to check-in to trunk? It looks like that trunk doesn't have the changes of bug 344476, bug 351644 and bug 351645.

Comment 68

[Robert Strong (they/them - no direct email)]

No, this patch must not go on the trunk and is not needed on the trunk. The reason the size is different on the branch is due to not being able to use the MS Shell Dlg font on East Asian versions of Win9x and since we don't support Win9x on the trunk we are using MS Shell Dlg on the trunk. See bug 344476 for more info and specifically bug 344476 comment #12.

Comment 69

[Robert Strong (they/them - no direct email)]

btw: you can also see what the ui looks like on the trunk in attachment #237149 [details] in bug 344476

Comment 70

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH.

Note: just to be careful again... this is not needed on the trunk.

Comment 71

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you, Robert for your checked-in.

I confirmed to fix in Fx-Official installer.
# from CVS.

-> v.