345047 - Universal Build fixup for XULRunner

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect, P1)

Description

[Benjamin Smedberg]

XULRunner 1.8.0.6 needs to be UB, and in order to accomplish this it will be necessary to fixup some packaging issues in the code which makes the final framework/.pkg.

Comment 1

[Benjamin Smedberg]

Attachment: Hit it with a cluestick, rev. 1

flight.mk still falls down pretty hard when I try to do FF+XR universal builds... but that can wait for at least a couple weeks. I've tested this with XR regular and universal and I'm testing FF universal.

Comment 2

[Mark Mentovai]

Comment on attachment 234345 [details] [diff] [review]
Hit it with a cluestick, rev. 1

>Index: build/macosx/universal/flight.mk

>+ifeq ($(MOZ_BUILD_APP),macbrowser) # {
> INSTALLER_DIR = camino/installer
> MOZ_PKG_APPNAME = camino
>+APPNAME = Camino$(DBGTAG).app

There's no such thing as CaminoDebug.app, although the existing flight.mk made it seem like there would be.  It's always Camino.app, even in a debug build.  The new structure makes this easy to fix now.  r+ with that change.

Comment 3

[Benjamin Smedberg]

Fixed on trunk.

Comment 4

[Benjamin Smedberg]

Comment on attachment 234345 [details] [diff] [review]
Hit it with a cluestick, rev. 1

We're going to try to get UB builds for XR 1807 and 181.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 234345 [details] [diff] [review]
Hit it with a cluestick, rev. 1

a scared approval for 1.8.0 branch, a=dveditz for drivers.

Please land ASAP so we can verify this doesn't break FF-UB. Our 1.8.0.7 code freeze is this weekend since we're trying to ship far in advance of FF2. Alternatively we could wait until after 1.8.0.7 and shoot for 1.8.0.8 which will be roughly the same time as FF2 (maybe a week or two behind, whatever it takes for release and QA).

Comment 6

[Benjamin Smedberg]

Fixed on MOZILLA_1_8_0_BRANCH

Comment 7

[Mike Schroepfer]

Comment on attachment 234345 [details] [diff] [review]
Hit it with a cluestick, rev. 1

a=schrep for drivers - approving all [181approval pending] bugs now that the tree is open.

Comment 8

[Benjamin Smedberg]

Fixed on MOZILLA_1_8_BRANCH