359687 - XULRunner pkg packages should correctly follow filename specs

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Robert Kaiser]

Currently, XULRunner mac packages are called e.g. xulrunner-pkg-1.9a1.en-US.mac.dmg but this does not follow our package filename convention, in that the "-pkg" part should not be added to the app name but to the platform as a "special" indicator, see http://developer.mozilla.org/en/docs/Package_Filename_Convention

This can easily be achieved by using the MOZ_PKG_SPECIAL var instead of changing MOZ_PKG_APPNAME and I'll attach a patch for that shortly.

Comment 1

[Robert Kaiser]

Attachment: use MOZ_PKG_SPECIAL instead of changing MOZ_PKG_APPNAME

This one-liner should do it. Unfortunately I can test this here, as I got no mac XULRunner tree...

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: matching change for Nagios nightly files check

Comment 3

[Robert Kaiser]

Fixed on trunk (including nagios check file)

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 244812 [details] [diff] [review]
use MOZ_PKG_SPECIAL instead of changing MOZ_PKG_APPNAME

approved for 1.8/1.8.0 branch, a=dveditz for drivers

Comment 5

[Robert Kaiser]

checked into both branches and fixed the one remaining nagios check (1.8 currently has no mac builds)

Comment 6

[jhp (no longer active)]

This seems to have made it so that XULRunner/Mac disk image now packages a folder rather than an installer.  Opened as bug 370243.