345083 - hang during session restore, kill ff, crash on next start [@ DocumentViewerImpl::Destroy]

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[aja+bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060717 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060718 BonEcho/2.0b1 ID:2006071804

hang during session restore, kill ff, crash on next start

TB21085506E - crash on restart (using session restore) 
TB21086894Z
TB21086929K

works okay again once i backed off to 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060717 BonEcho/2.0b1 ID:2006071708

Reproducible: Always

Steps to Reproduce:
1. with browser.sessionstore.resume_session=true, shutdown ff
2. start ff, 1 or more tabs are hung
3. kill ff


Actual Results:  
crashes on next startup

Expected Results:  
should'nt hang on startup
shouldn't crash on later startups

Console² 0.3.5.3+
DOM Inspector 1.8.1b1
Link Toolbar 1.1.0.1
Mozilla Accessibility Extension 0.99.1.2580
Mozilla XForms 0.6
Nightly Tester Tools 1.1
Talkback 2.0b1
Update Channel Selector 1.0.1
Web Developer 1.0.2

Comment 1

[Dietrich Ayala (:dietrich)]

I installed this nightly on a winxp vm that only had B1 installed, and it crashed at first startup. Still working on a reliable reproduction scenario. Looking through the regression range, there's nothing related to session restore that stands out:

http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-07-17+&maxdate=2006-07-18&cvsroot=%2Fcvsroot

Comment 2

[Dietrich Ayala (:dietrich)]

Update: I can reproduce a similar scenario every few restarts. However, I don't get a hang, nor crash on restart. For me it crashes while loading documents at startup (eg: all tabs have been created already, but docs are still loading), and it works fine on the next restart.

Comment 3

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060718 BonEcho/2.0b1 ID:2006071804

without browser.sessionstore.resume_session=true,

while browsing, often hang/freeze and sometimes crash.

one of TBs.
TB21100246M

Comment 4

[Dietrich Ayala (:dietrich)]

(In reply to comment #3)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060718
> BonEcho/2.0b1 ID:2006071804
> 
> without browser.sessionstore.resume_session=true,
> 
> while browsing, often hang/freeze and sometimes crash.
> 
> one of TBs.
> TB21100246M
> 

I confirmed this: I get crashes while browsing, a few minutes after a restart, when resume_session=false. However, I have not been able to reproduce a crash with session restore disabled entirely (browser.sessionstore.enabled=false), which indicates that session restore is related somehow.

Comment 5

[Doug Halamay]

Take your pick (all from the 2006071804 nightly):

http://talkback-public.mozilla.org/search/start.jsp?search=1&searchby=stacksig&match=contains&searchfor=&vendor=MozillaOrg&product=Firefox2&platform=Win32&buildid=2006071804&sdate=&stime=&edate=&etime=&sortby=bbid&rlimit=0

Comment 6

[Dietrich Ayala (:dietrich)]

Update: Reverting my changes from the regression period (bug 342454) does not fix this bug. I'll continue to investigate the other checkins in that period that may have caused/exposed this, as well as try to narrow down exactly what session restore is doing when this occurs.

Comment 7

[Martijn Wargers (dead)]

I suspect this is a regression from bug 314549. See also comments in bug 345151 which has the same stacktrace.

Comment 8

[Dietrich Ayala (:dietrich)]

(In reply to comment #7)
> I suspect this is a regression from bug 314549. See also comments in bug 345151
> which has the same stacktrace.
> 

Thanks Martijn, bug 314549 is probably the culprit. I don't have access to bug 345151, so wasn't able to take a look.

Comment 9

[Adam Guthrie]

Incident ID: 21086894
Stack Signature	0x00000000 5739c893
Product ID	Firefox2
Build ID	2006071804
Trigger Time	2006-07-18 10:01:43.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	
URL visited	
User Comments	
Since Last Crash	1587 sec
Total Uptime	2101 sec
Trigger Reason	Access violation
Source File, Line No.	N/A
Stack Trace 	
0x00000000
DocumentViewerImpl::Destroy  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsDocumentViewer.cpp, line 1497]
DocumentViewerImpl::Show  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsDocumentViewer.cpp, line 1837]
nsPresContext::EnsureVisible  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresContext.cpp, line 1311]
PresShell::UnsuppressAndInvalidate  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 5034]
PresShell::ProcessReflowCommands  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6950]
ReflowEvent::HandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/base/nsPresShell.cpp, line 6708]
PL_HandleEvent  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/xpcom/threads/plevent.c, line 689]
0x778b0c24
nsFieldSetFrame::Reflow  [c:/builds/tinderbox/Fx-Mozilla1.8/WINNT_5.2_Depend/mozilla/layout/forms/nsFieldSetFrame.cpp, line 404]
0x4d8d14c4

Comment 10

[Reed Loden [:reed]]

Fix loss of blocking flag and TM change.

Comment 11

[Jesse Maloney (jtmal0723 [at] gmail for email)]

(In reply to comment #10)
> Fix loss of blocking flag and TM change.
> 

wrong target milestone. you want mozilla1.8.1beta2, not mozilla1.8beta2. Someone please fix this

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

*** Bug 345340 has been marked as a duplicate of this bug. ***

Comment 13

[Boris Zbarsky [:bzbarsky]]

Is this still an issue now that the crash in bug 314549 has been fixed?

Comment 14

[aja+bugzilla]

(In reply to comment #13)
> Is this still an issue now that the crash in bug 314549 has been fixed?
> 
It's working fine for me now, bz.  

Comment 15

[Jesse Maloney (jtmal0723 [at] gmail for email)]

It looks like it's working fine on my end too, I confirm.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060722 BonEcho/2.0b1 ID:2006072203

Comment 16

[Tracy Walker [:tracy]]

verified with Windows 2.0b2 build of  20060821