345084 - NSIS Installed build prompts to become the default app

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Scott MacGregor]

The first time you install a version of Thunderbird using the NSIS installer, Thunderbird thinks it isn't the default mail application.

I still need to dig some more, but the root of the problem is the use of 8.3 paths in the keys the old installer wrote out. 

Our default app code compares the following two keys in order to determine if this particular installation is the default mail client (the 2nd key is written to by the installer)

HKEY_LOCAL_MACHINE\SOFTWARE\Classes\mailto\shell\open\command

and

HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\Mozilla Thunderbird\protocols\mailto\shell\open\command


The value for Classes\mailto is always:
C:\PROGRA~1\MOZILL~2\THUNDE~1.EXE -compose %1  (Note the 8.3 notation)

The old installer wrote 8.3 into Mozilla Thunderbird\protocols\mailto\shell\open\command:
C:\PROGRA~1\MOZILL~2\THUNDE~1.EXE -compose "%1"

The new installer writes:
C:\Program Files\Mozilla Thunderbird\thunderbird.exe -compose "%1"
for the same key.

So the default app code ends up comparing:
C:\Program Files\Mozilla Thunderbird\thunderbird
to
C:\PROGRA~1\MOZILL~2\THUNDE~1

and determines that those strings are not the same, so we must not be the default mail app.

The code is here:

http://lxr.mozilla.org/mozilla/source/mailnews/mapi/mapihook/src/nsMapiRegistryUtils.cpp#320

Comment 1

[Scott MacGregor]

Attachment: the fix

Rob, this patch does the following:

1) Registers the MapiProxy.dll which the old mail.jst file was doing. I left the same comment you had in there for AccessibleMarshal.dll. 

2) Adds in the MAPI DLLPath key which was missing.

3) Creates a variable for the short path to the .exe and uses it for several keys.

Note: The old installer used full paths for the entries under InstallInfo and DefaultIcon so I left those alone. Although we could force them to all be consistent with 8.3 names. 

Lemme know if you want to change Firefox or calendar to use 8.3 names.

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 229749 [details] [diff] [review]
the fix

Looks good. I'll take a look at the Firefox and Calendar cases to see if it is necessary. Thanks

Comment 3

[Scott MacGregor]

I landed this a while ago, I must not have been logged into bugzilla when I closed it out.