345238 - Make XPFE alerts service use alert origin reported by look and feel

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Jens Bannmann]

Bug 133527 introduced an alert origin value and changed the toolkit alerts service to use it. As the next SeaMonkey release will not yet use toolkit, we need to add alert origin support to the XPFE alerts service.

Comment 1

[Simon Montagu :smontagu]

Jens, do you mind if I take this? I've done some of the work already to help debug bug 132733.

Comment 2

[Simon Montagu :smontagu]

Attachment: Port jens' patch (attachment 229835) to xpfe

Comment 3

[[e-mail]]

Comment on attachment 247676 [details] [diff] [review]
Port jens' patch (attachment 229835 [details] [diff] [review]) to xpfe

If biesi prefers you can call this an r+ and he can give sr+

Comment 4

[Jens Bannmann]

(In reply to comment #1)
> Jens, do you mind if I take this? I've done some of the work already to help
> debug bug 132733.

No, not at all! I wouldn't have the time anyway, thanks for making this happen.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 247676 [details] [diff] [review]
Port jens' patch (attachment 229835 [details] [diff] [review]) to xpfe

xpfe/components/alerts/src/Makefile.in
             dom \
+            widget \
+	    gfx \

wrong indentation on the gfx line

sr=biesi, marking r=neil per comment 3

Comment 6

[Simon Montagu :smontagu]

Checked in.