Open
Bug 345288
Opened 19 years ago
Updated 4 years ago
query result rows should have classes for the assignee, reporter, qacontact, and preferably a me class
Categories
(Bugzilla :: Query/Bug List, enhancement)
Tracking
()
NEW
People
(Reporter: timeless, Unassigned)
References
()
Details
(Keywords: ue)
Attachments
(1 file, 1 obsolete file)
|
2.34 KB,
patch
|
mkanat
:
review-
|
Details | Diff | Splinter Review |
If you have a long query, you will get something like:
ID Sev Pri Plt Assignee Reporter Status Resolution Product Summary
<bugs...>
ID Sev Pri Plt Assignee Reporter Status Resolution Product Summary
<morebugs...>
ID Sev Pri Plt Assignee Reporter Status Resolution Product Summary
<morebugs...>
Steps to reproduce:
If you really want such a query, search for all timeless's bugs
https://bugzilla.mozilla.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailassigned_to1=1&emailreporter1=1&emailtype1=exact&email1=timeless%40bemail.org&field0-0-0=bug_status&type0-0-0=notequals&value0-0-0=UNCONFIRMED&field0-0-1=reporter&type0-0-1=equals&value0-0-1=timeless%40bemail.org
This is a fairly big query. now suppose you wanted to say color code each row based on whether timeless was the reporter, qa contact, or assignee. If you had a CSS3Selector capable browser you could try using :contents() but gecko doesn't implement that, and it's ugly and silly and expensive
Expected results (from working with someone who just learned about userContent.css):
Each row should have a series of classes for the major involved users
bz_assi_user_name_host_name bz_repo_user_name_host_name
bz_qa_user_name_host_name
The specific encoding to use for the class names is left as an implementation detail. One note of caution. Users tend to rename themselves, as such, I'd personally rather bz_qa_user10 because having to fix my css file on 30 computers just because someone changed their email address isn't something i'd enjoy doing.
the me bit is interesting
i'm not sure how it should be done, but my colleague suggested that most of the time he only really cared about himself, so a bz_me match might be good enough for him, but his query was essentially a "my bugs" query, so i'm not quite sure how helpful that would be.
I think he would want the bz_me bit to be a class on a <td> instead of a <tr> so that he can highlight his own name specifically in the row.
Note that the role things should be on the row whether or not the fields they reference are visible.
Assignee: query-and-buglist → timeless
Status: NEW → ASSIGNED
Attachment #273724 -
Flags: review?(LpSolit)
Comment 2•18 years ago
|
||
Comment on attachment 273724 [details] [diff] [review]
something like this
>Index: template/en/default/list/table.html.tmpl
> [% FOREACH column = displaycolumns %]
>+ [% ' class="bz_me"' IF bug.$column == user.login -%]>
Besides the fact I'm not sure how useful this RFE is, you should compare what is comparable. You compare user->login against each column, independently of what the column means. Non-sense.
Attachment #273724 -
Flags: review?(LpSolit) → review-
Attachment #273724 -
Attachment is obsolete: true
Attachment #274345 -
Flags: review?(LpSolit)
Comment 4•18 years ago
|
||
Comment on attachment 274345 [details] [diff] [review]
no me class
I'm not a fan of having tens of classes. And a more logical class name would be bz_reporter_$id IMO. Reassigning the request to someone else who may be more interested than me in reviewing this patch.
Attachment #274345 -
Flags: review?(LpSolit) → review?(mkanat)
Comment 5•18 years ago
|
||
Comment on attachment 274345 [details] [diff] [review]
no me class
I'd be OK with a "me" class, but I'm not interested in the others.
Attachment #274345 -
Flags: review?(mkanat) → review-
Updated•12 years ago
|
Assignee: timeless → query-and-buglist
Updated•12 years ago
|
Status: ASSIGNED → NEW
You need to log in
before you can comment on or make changes to this bug.
Description
•